-
Notifications
You must be signed in to change notification settings - Fork 21
DEP-233 and 235: add language switching in public and preview interfaces #2870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NatSquared
merged 6 commits into
DEP-234-authoring-language-switching
from
DEP-233-235-public-language-switcher
Jun 11, 2026
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
37e479a
DEP-233 and 235: add language switching in public and preview interfaces
NatSquared 84fdde0
Update CHANGELOG.md
NatSquared 8a7948e
Fix lint + test errors
NatSquared 511c023
Fix more test errors
NatSquared 03c2e5b
Add loader to engagement language switcher
NatSquared 0babf2a
use ConvertToPacific in engagement hero
NatSquared File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
web/src/components/engagement/preview/PreviewLanguageSwitcher.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import React from 'react'; | ||
| import { useNavigate, useParams } from 'react-router'; | ||
| import { useEngagementLoaderData } from './PreviewLoaderDataContext'; | ||
| import { ROUTES, getPath } from 'routes/routes'; | ||
| import EngagementLanguageSwitcher from 'components/engagement/shared/EngagementLanguageSwitcher'; | ||
|
|
||
| export const PreviewLanguageSwitcher = () => { | ||
| const navigate = useNavigate(); | ||
| const { engagementId, languageCode } = useParams(); | ||
| const { translationLanguages } = useEngagementLoaderData(); | ||
|
|
||
| if (!engagementId || !translationLanguages) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <EngagementLanguageSwitcher | ||
| menuName="Preview Language Menu" | ||
| translationLanguages={translationLanguages} | ||
| currentLanguageCode={languageCode} | ||
| onLanguageSelect={(nextLanguageCode) => { | ||
| globalThis.sessionStorage.setItem('languageId', nextLanguageCode); | ||
| navigate( | ||
| getPath(ROUTES.ADMIN_ENGAGEMENT_PREVIEW, { | ||
| engagementId, | ||
| languageCode: nextLanguageCode, | ||
| }), | ||
| ); | ||
| }} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default PreviewLanguageSwitcher; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for unifying the language switchers