Update dev Graphemes API deployment to use GHCR#74
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the development deployment of the Graphemes API to pull its container image from GitHub Container Registry (GHCR) instead of an OpenShift ImageStream.
- Removed legacy ImageStream triggers and annotations.
- Updated the
imagefield to point toghcr.io/bcgov/standard-graphemes/graphemes-api:dev.
Comments suppressed due to low confidence (1)
graphemes-api/openshift/dev/deployment.yaml:29
- If the GHCR registry requires authentication, add an
imagePullSecretsentry underspec:to allow pulling private images (e.g., `imagePullSecrets:- name: ghcr-registry-secret`).
spec:
| containers: | ||
| - name: graphemes-api | ||
| image: "image-registry.openshift-image-registry.svc:5000/f343b4-tools/graphemes-api:dev" | ||
| image: ghcr.io/bcgov/standard-graphemes/graphemes-api:dev |
There was a problem hiding this comment.
[nitpick] Consider adding imagePullPolicy: Always for the dev deployment to ensure Kubernetes always pulls the latest :dev image rather than using a potentially cached image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
devnamespace deployment for the Graphemes API to point to the image hosted on GHCR instead of an OpenShift ImageStream (see #69 and #72).