Skip to content

Update dev Graphemes API deployment to use GHCR #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ty2k merged 1 commit into from
May 20, 2025
Merged

Update dev Graphemes API deployment to use GHCR #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions graphemes-api/openshift/dev/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,20 @@ metadata:
annotations:
alpha.image.policy.openshift.io/resolve-names: "*"
app.openshift.io/route-disabled: "false"
deployment.kubernetes.io/revision: "1"
image.openshift.io/triggers: '[{"from":{"kind":"ImageStreamTag","name":"graphemes-api:dev","namespace":"f343b4-tools"},"fieldPath":"spec.template.spec.containers[?(@.name==\"graphemes-api\")].image","paused":"false"}]'
openshift.io/generated-by: OpenShiftWebConsole
spec:
replicas: 2
selector:
matchLabels:
app: graphemes-api
triggers:
- type: ImageChange
imageChangeParams:
automatic: true
containerNames:
- graphemes-api
from:
kind: ImageStreamTag
name: graphemes-api:dev
namespace: f343b4-tools
template:
metadata:
creationTimestamp: null
labels:
app: graphemes-api
deployment: graphemes-api
annotations:
openshift.io/generated-by: OpenShiftWebConsole
spec:
containers:
- name: graphemes-api
image: "image-registry.openshift-image-registry.svc:5000/f343b4-tools/graphemes-api:dev"
image: ghcr.io/bcgov/standard-graphemes/graphemes-api:dev
Copy link

Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding imagePullPolicy: Always for the dev deployment to ensure Kubernetes always pulls the latest :dev image rather than using a potentially cached image.

Copilot uses AI. Check for mistakes.
ports:
- containerPort: 3000
protocol: TCP
Expand Down