Task/kbdev 1537 update fulltext queries#106
Draft
mathieulemieux wants to merge 5 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #106 +/- ##
===========================================
- Coverage 86.26% 86.14% -0.12%
===========================================
Files 46 46
Lines 3341 3350 +9
Branches 873 879 +6
===========================================
+ Hits 2882 2886 +4
- Misses 399 404 +5
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathieulemieux
commented
May 28, 2026
| @@ -131,6 +132,7 @@ const createSchema = async (db) => { | |||
| type: 'unique', | |||
| }))); | |||
Member
Author
There was a problem hiding this comment.
@elewis2 , here are some hardcoded indexes in the API, in addition to the ones provided per class by the schema.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@elewis2 , we may want to implement the index part in the schema directly now that we can see it's passing the tests. Otherwise, I need to add a functionality that checks, for an existing DB, that the index already or creates it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, only Ontology have FULLTEXT indexes, and this PR is only adding a LUCENE index to that class.
But there is possibility to do CONTAINSTEXT queries (so leveraging FULLTEXT sql queries) on other class too (like variants), and this default to a 'per record scan' from what I'm understanding.