Skip to content

Conversation

@mathieulemieux
Copy link
Member

No description provided.

@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.70%. Comparing base (816ea2a) to head (ce01fe5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #98   +/-   ##
========================================
  Coverage    56.70%   56.70%           
========================================
  Files          102      102           
  Lines         3890     3890           
  Branches      1316     1316           
========================================
  Hits          2206     2206           
  Misses        1672     1672           
  Partials        12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mathieulemieux
Copy link
Member Author

@elewis2 and @kttkjl , do you see any issue with that? Since I'm about to release a new minor version of the schema...

@mathieulemieux
Copy link
Member Author

mathieulemieux commented Oct 29, 2025

@areisle , do you see or remember a reason why the client is not auto-upgrading the client version on minor changes while it's the case for the api? For the api I'm actually thinking it would be better without it.

@mathieulemieux
Copy link
Member Author

Closed as won't do, since it seems preferable to make schema version change explicit.

@mathieulemieux
Copy link
Member Author

reopening with patch version auto-upgradable instead, like with the API in bcgsc/pori_graphkb_api#88.

@github-actions

This comment has been minimized.

@mathieulemieux mathieulemieux merged commit c5cbc8f into develop Oct 30, 2025
3 checks passed
@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

    1 files  ±0    39 suites  ±0   1m 32s ⏱️ -7s
160 tests ±0  159 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
156 runs  ±0  155 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit c5cbc8f. ± Comparison against base commit 816ea2a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants