feature/KBDEV-1502 cosmic loader update#195
Conversation
|
@sshugsc, do you have the upload logs from you tests? |
|
@mathieulemieux logs could be found at jira ticket KBDEV-1502 |
|
@sshugsc, I'll need either the cosmic files, or the cosmic email/password. |
|
@mathieulemieux sent by rocket chat |
| } | ||
| } else { | ||
| logger.info('Cannot delete previously existing statements when errors were encoutered'); | ||
| } |
There was a problem hiding this comment.
Errors happened when testing, indeed. Seems bad to not beeing able to delete any statements because of a single error. I'm wondering if we can think of something better.
There was a problem hiding this comment.
yea, that would be ideal but we don't have a way to match the new created statements with the original statements. It would be difficult to decide which statement should not be deleted. @elewis2 any thoughts?
|
@elewis2 , should we implement tests here or it's out of scope for this ticket/loader? |
Yes, tests should be included in this work. |
3 participants
KBDEV-1502