Feat/devsu 2539 create tags at report upload#449
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #449 +/- ##
===========================================
+ Coverage 77.00% 77.04% +0.03%
===========================================
Files 182 183 +1
Lines 6367 6395 +28
Branches 750 758 +8
===========================================
+ Hits 4903 4927 +24
- Misses 1379 1382 +3
- Partials 85 86 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ], | ||
| "observedVariantAnnotations": [ | ||
| { | ||
| "variant": "test3", |
Contributor
There was a problem hiding this comment.
is this supposed to be variantId per line 150 of createReport.js?
Collaborator
Author
There was a problem hiding this comment.
No, "variant" is doing the same thing in this section as it is doing in the kbMatches section - the value is the key to the record in the (small mutations in this case) variant section.
Collaborator
Author
There was a problem hiding this comment.
since variantId won't be available until after the variant record is created in the db
…//github.com/bcgsc/pori_ipr_api into feat/DEVSU-2539-create-tags-at-report-upload
bnguyen-bcgsc
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates create-report functionality to create observedVariantAnnotations at report load time if these are included in the report json under the section name 'observedVariantAnnotations'.