Skip to content

Feat/devsu 2539 create tags at report upload#449

Merged
elewis2 merged 13 commits into
developfrom
feat/DEVSU-2539-create-tags-at-report-upload
Jun 27, 2025
Merged

Feat/devsu 2539 create tags at report upload#449
elewis2 merged 13 commits into
developfrom
feat/DEVSU-2539-create-tags-at-report-upload

Conversation

@elewis2

@elewis2 elewis2 commented May 29, 2025

Copy link
Copy Markdown
Collaborator

Updates create-report functionality to create observedVariantAnnotations at report load time if these are included in the report json under the section name 'observedVariantAnnotations'.

@codecov-commenter

codecov-commenter commented May 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (55ae893) to head (929ef3a).

Files with missing lines Patch % Lines
app/libs/createReport.js 80.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #449      +/-   ##
===========================================
+ Coverage    77.00%   77.04%   +0.03%     
===========================================
  Files          182      183       +1     
  Lines         6367     6395      +28     
  Branches       750      758       +8     
===========================================
+ Hits          4903     4927      +24     
- Misses        1379     1382       +3     
- Partials        85       86       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elewis2 elewis2 requested review from bnguyen-bcgsc and sshugsc May 29, 2025 19:02
Comment thread app/libs/createReport.js Outdated
],
"observedVariantAnnotations": [
{
"variant": "test3",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be variantId per line 150 of createReport.js?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, "variant" is doing the same thing in this section as it is doing in the kbMatches section - the value is the key to the record in the (small mutations in this case) variant section.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since variantId won't be available until after the variant record is created in the db

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see I see

@elewis2 elewis2 requested a review from bnguyen-bcgsc June 2, 2025 21:36
@elewis2 elewis2 merged commit 5ea6d17 into develop Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants