Bugfix/devsu 2539 include nonkbmatched variants in table3#468
Merged
elewis2 merged 3 commits intoOct 31, 2025
Merged
Conversation
…bugfix/DEVSU-2539-include-nonkbmatched-variants-in-table3
| await db.models.report.destroy({where: {ident: reportIdent.ident}}); | ||
| }); | ||
|
|
||
| test('Variants with no kbmatches can be put in table 3 if gene is tumourSuppressor, cancergenelist or oncogene - OK', async () => { |
Member
There was a problem hiding this comment.
Non-blocking: was wondering if we would like to have getRapidReportVariants() tested independently of report creation, by attaching to router._testUtils ?
mathieulemieux
previously approved these changes
Oct 31, 2025
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #468 +/- ##
===========================================
+ Coverage 77.32% 77.33% +0.01%
===========================================
Files 185 185
Lines 6667 6680 +13
Branches 826 831 +5
===========================================
+ Hits 5155 5166 +11
- Misses 1424 1426 +2
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathieulemieux
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the rapid reports summary page, for table 3 only, include variants if the genes they are associated with have tumourSuppressor = true, cancerGeneListMatch = true, or oncgene = true, even if these variants don't have kbmatches.