Skip to content

Commit 4985015

Browse files
committed
Feat: Tumour Summary Edit code clean up
- DEVSU-2201 - Make changes as requested on PR 415, which include: - Adjust default mutation burden analysis role - Remove debug console log - Clean up mutation burden data edit to be in line with updated tumour mutation burden section from DEVSU-2148 #416 - Remove report type check for both mutation burden edit (sv count and percentile) and tumour burden edit (genomeSnvTmb and genomeIndelTmb)
1 parent ecfffe3 commit 4985015

File tree

2 files changed

+29
-69
lines changed

2 files changed

+29
-69
lines changed

app/components/TumourSummaryEdit/index.tsx

+29-68
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ const TumourSummaryEdit = ({
148148
if (mutationBurden?.ident) {
149149
apiCalls.push(api.put(`/reports/${report.ident}/mutation-burden/${mutationBurden.ident}`, newMutationBurdenData, {}));
150150
} else {
151-
newMutationBurdenData.role = 'primary'; // Default role of new mutation burden data for reports with no existing analysis per ClinInfo team
152-
apiCalls.push(api.post(`/reports/${report.ident}/mutation-burden`, newMutationBurdenData, {}));
151+
// Default role of new mutation burden data for reports with no existing analysis per ClinInfo team
152+
apiCalls.push(api.post(`/reports/${report.ident}/mutation-burden`, { ...newMutationBurdenData, role: 'primary' }, {}));
153153
}
154154
} else {
155155
apiCalls.push({ request: () => null });
@@ -328,48 +328,12 @@ const TumourSummaryEdit = ({
328328
}, [handleClicked, handleDelete, handleKeyDown, newMicrobialData]);
329329

330330
const mutBurDataSection = useMemo(() => {
331-
if (newMutationBurdenData) {
332-
return (
333-
<>
334-
<TextField
335-
className="tumour-dialog__text-field"
336-
label="Mutation Burden (Mut/Mb)"
337-
value={newMutationBurdenData.totalMutationsPerMb}
338-
name="totalMutationsPerMb"
339-
onChange={handleMutationBurdenChange}
340-
variant="outlined"
341-
fullWidth
342-
type="number"
343-
/>
344-
<TextField
345-
className="tumour-dialog__text-field"
346-
label="SV Burden (POG average)"
347-
value={newMutationBurdenData.qualitySvCount}
348-
name="qualitySvCount"
349-
onChange={handleMutationBurdenChange}
350-
variant="outlined"
351-
fullWidth
352-
type="number"
353-
/>
354-
<TextField
355-
className="tumour-dialog__text-field"
356-
label="SV Burden (Percentile)"
357-
value={newMutationBurdenData.qualitySvPercentile}
358-
name="qualitySvPercentile"
359-
onChange={handleMutationBurdenChange}
360-
variant="outlined"
361-
fullWidth
362-
type="number"
363-
/>
364-
</>
365-
);
366-
}
367331
return (
368332
<>
369333
<TextField
370334
className="tumour-dialog__text-field"
371335
label="Mutation Burden (Mut/Mb)"
372-
value={null}
336+
value={newMutationBurdenData?.totalMutationsPerMb ?? null}
373337
name="totalMutationsPerMb"
374338
onChange={handleMutationBurdenChange}
375339
variant="outlined"
@@ -379,7 +343,7 @@ const TumourSummaryEdit = ({
379343
<TextField
380344
className="tumour-dialog__text-field"
381345
label="SV Burden (POG average)"
382-
value={null}
346+
value={newMutationBurdenData?.qualitySvCount ?? null}
383347
name="qualitySvCount"
384348
onChange={handleMutationBurdenChange}
385349
variant="outlined"
@@ -389,7 +353,7 @@ const TumourSummaryEdit = ({
389353
<TextField
390354
className="tumour-dialog__text-field"
391355
label="SV Burden (Percentile)"
392-
value={null}
356+
value={newMutationBurdenData?.qualitySvPercentile ?? null}
393357
name="qualitySvPercentile"
394358
onChange={handleMutationBurdenChange}
395359
variant="outlined"
@@ -401,33 +365,30 @@ const TumourSummaryEdit = ({
401365
}, [newMutationBurdenData, handleMutationBurdenChange]);
402366

403367
const tmburMutBurSection = useMemo(() => {
404-
if (newTmburMutData) {
405-
return (
406-
<>
407-
<TextField
408-
className="tumour-dialog__text-field"
409-
label="genomeSnvTmb"
410-
value={newTmburMutData.genomeSnvTmb}
411-
name="genomeSnvTmb"
412-
onChange={handleTmburChange}
413-
variant="outlined"
414-
fullWidth
415-
type="number"
416-
/>
417-
<TextField
418-
className="tumour-dialog__text-field"
419-
label="genomeIndelTmb"
420-
value={newTmburMutData.genomeIndelTmb}
421-
name="genomeIndelTmb"
422-
onChange={handleTmburChange}
423-
variant="outlined"
424-
fullWidth
425-
type="number"
426-
/>
427-
</>
428-
);
429-
}
430-
return null;
368+
return (
369+
<>
370+
<TextField
371+
className="tumour-dialog__text-field"
372+
label="genomeSnvTmb"
373+
value={newTmburMutData?.genomeSnvTmb ?? null}
374+
name="genomeSnvTmb"
375+
onChange={handleTmburChange}
376+
variant="outlined"
377+
fullWidth
378+
type="number"
379+
/>
380+
<TextField
381+
className="tumour-dialog__text-field"
382+
label="genomeIndelTmb"
383+
value={newTmburMutData?.genomeIndelTmb ?? null}
384+
name="genomeIndelTmb"
385+
onChange={handleTmburChange}
386+
variant="outlined"
387+
fullWidth
388+
type="number"
389+
/>
390+
</>
391+
);
431392
}, [newTmburMutData, handleTmburChange]);
432393

433394
return (

app/views/ReportView/components/RapidSummary/index.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ const RapidSummary = ({
195195
setPrimaryBurden(null);
196196
} else {
197197
setPrimaryBurden(burdenResp[0]);
198-
console.log(burdenResp[0]); // For debug purpose
199198
}
200199
} catch (e) {
201200
// mutation burden does not exist in records before this implementation, and no backfill will be done on the backend, silent fail this

0 commit comments

Comments
 (0)