Skip to content

[DEVSU-2620] [DEVSU-2634] rapid summary updates #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

kttkjl
Copy link
Member

@kttkjl kttkjl commented May 6, 2025

[DEVSU-2620]
Don't delete entries when removing from summary

[DEVSU-2634]
Removed duplicate therapies on display

kttkjl added 3 commits May 2, 2025 18:34
  - sort by highest IPR levels, then alphabetically
  - updated the sort to be not just A and B, but all IPR levels
DEVSU-2634
@kttkjl kttkjl self-assigned this May 6, 2025
@kttkjl kttkjl requested review from elewis2 and bnguyen-bcgsc May 6, 2025 22:23
Copy link

github-actions bot commented May 6, 2025

Test Results

    1 files  ±0    28 suites  ±0   4m 56s ⏱️ -6s
145 tests ±0  145 ✔️ ±0  0 💤 ±0  0 ±0 
142 runs  ±0  142 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a266428. ± Comparison against base commit 1a7d465.

♻️ This comment has been updated with latest results.

@elewis2
Copy link
Collaborator

elewis2 commented May 6, 2025

Noting that this change means the mutation is not removed from the rapid report table when all treatments are hidden, leaving a variant row with 'sensitivity to' and nothing else displayed. Since there are more changes coming to the rapid reports summary kbmatches before next release I'm approving this pr anyway.

Copy link
Collaborator

@elewis2 elewis2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug - can't add a comment for high mutation burden variant type. maybe disable this field for that variant type (I believe it's getting processed as a signature variant) until we have a fix for that? alternatively maybe the comment can be stored in the observed-variants-annotations json field

@kttkjl
Copy link
Member Author

kttkjl commented May 7, 2025

Found a bug - can't add a comment for high mutation burden variant type. maybe disable this field for that variant type (I believe it's getting processed as a signature variant) until we have a fix for that? alternatively maybe the comment can be stored in the observed-variants-annotations json field

As discussed irl, let's make the front-end changes to check for the new type and then wait for observed-variants-annotations json field

@kttkjl kttkjl requested a review from elewis2 May 8, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants