DEVSU-2797 - improve error message logging when graphkb_conn is made with graphkb_url None

Author: dustinbleile

pori_python/graphkb/util.py

@@ -222,6 +222,8 @@ def login_demo(self) -> None:
         1. get a first token from KeyCloak using username and password; self.login_demo()
         2. get a second token from the GraphKB API using keyCloakToken; self.login()
         """
+        if not self.url:
+            raise ValueError("no self.url set - cannot make a login demo")
         url_parts = urlsplit(self.url)
         base_url = f"{url_parts.scheme}://{url_parts.netloc}"
 
@@ -251,7 +253,8 @@ def login(self, username: str, password: str, pori_demo: bool = False) -> None:
         read_timeout = 61
 
         # KBDEV-1328. Alt. GraphKB login for GSC's PORI online demo
-        if pori_demo or "pori-demo" in self.url:
+        if self.url and (pori_demo or "pori-demo" in self.url):
+            logger.warning(f"login demo")
             self.login_demo()
 
         # use requests package directly to avoid recursion loop on login failure

pori_python/ipr/main.py

@@ -417,14 +417,14 @@ def ipr_report(
     )
 
     # GKB CONNECTION
+    gkb_user = graphkb_username if graphkb_username else username
+    gkb_pass = graphkb_password if graphkb_password else password
     if graphkb_url:
         logger.info(f"connecting to graphkb: {graphkb_url}")
         graphkb_conn = GraphKBConnection(graphkb_url)
     else:
-        graphkb_conn = GraphKBConnection()
-
-    gkb_user = graphkb_username if graphkb_username else username
-    gkb_pass = graphkb_password if graphkb_password else password
+        # graphkb_conn = GraphKBConnection()  # This will just error on trying to login
+        raise ValueError("graphkb_url is required")
 
     graphkb_conn.login(gkb_user, gkb_pass)