fix(igp): corrected coin comparison#141
Merged
mbreithecker merged 2 commits intobcp-innovations:mainfrom Jan 23, 2026
Merged
Conversation
danwt
added a commit
to dymensionxyz/hyperlane-cosmos
that referenced
this pull request
Sep 22, 2025
29 tasks
mbreithecker
approved these changes
Jan 23, 2026
Member
mbreithecker
left a comment
mbreithecker
left a comment
There was a problem hiding this comment.
Good catch! Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
maxFeecheck in IGP is incorrect. It passes in unexpected scenarios. For example, ifrequiredPayment = 5uatomwhilemaxFee = 5uosmo.Ideally, we'd use
requiredPayment.IsAnyGT(maxFee), butIsAnyGTsemantic is weird (see issue). The correct alternative is!maxFee.IsAllGTE(requiredPayment).I added a test to cover this case.