Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new realm configuration for AWI BEC development virtual machines to the developer machines deployment configuration. It introduces a new PSI_office_BEC_VM realm with six development VMs (awi-bec-dev-01 through awi-bec-dev-06) managed by the unx-bec_core group.
- Adds PSI_office_BEC_VM realm configuration with unx-bec_core as the manager group
- Configures six AWI BEC development VMs with consistent naming and access patterns
- All VMs are configured with identical access permissions for the unx-bec_core group
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| awi-bec-dev-01.psi.ch: | ||
| name: AWI BEC Development VM 01 |
There was a problem hiding this comment.
[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.
| awi-bec-dev-02.psi.ch: | ||
| name: AWI BEC Development VM 02 |
There was a problem hiding this comment.
[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.
| awi-bec-dev-03.psi.ch: | ||
| name: AWI BEC Development VM 03 |
There was a problem hiding this comment.
[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.
| awi-bec-dev-01.psi.ch: | ||
| name: AWI BEC Development VM 01 | ||
| description: Development machine in the office network | ||
| deployment_access: | ||
| - unx-bec_core | ||
| experiment_access: | ||
| - unx-bec_core | ||
| awi-bec-dev-02.psi.ch: | ||
| name: AWI BEC Development VM 02 | ||
| description: Development machine in the office network | ||
| deployment_access: | ||
| - unx-bec_core | ||
| experiment_access: | ||
| - unx-bec_core | ||
| awi-bec-dev-03.psi.ch: | ||
| name: AWI BEC Development VM 03 | ||
| description: Development machine in the office network | ||
| deployment_access: | ||
| - unx-bec_core | ||
| experiment_access: | ||
| - unx-bec_core | ||
| awi-bec-dev-04.psi.ch: | ||
| name: AWI BEC Development VM 04 | ||
| description: Development machine in the office network | ||
| deployment_access: | ||
| - unx-bec_core | ||
| experiment_access: | ||
| - unx-bec_core | ||
| awi-bec-dev-05.psi.ch: | ||
| name: AWI BEC Development VM 05 | ||
| description: Development machine in the office network | ||
| deployment_access: | ||
| - unx-bec_core | ||
| experiment_access: | ||
| - unx-bec_core | ||
| awi-bec-dev-06.psi.ch: | ||
| name: AWI BEC Development VM 06 | ||
| description: Development machine in the office network | ||
| deployment_access: | ||
| - unx-bec_core | ||
| experiment_access: | ||
| - unx-bec_core |
There was a problem hiding this comment.
[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.
| awi-bec-dev-01.psi.ch: | |
| name: AWI BEC Development VM 01 | |
| description: Development machine in the office network | |
| deployment_access: | |
| - unx-bec_core | |
| experiment_access: | |
| - unx-bec_core | |
| awi-bec-dev-02.psi.ch: | |
| name: AWI BEC Development VM 02 | |
| description: Development machine in the office network | |
| deployment_access: | |
| - unx-bec_core | |
| experiment_access: | |
| - unx-bec_core | |
| awi-bec-dev-03.psi.ch: | |
| name: AWI BEC Development VM 03 | |
| description: Development machine in the office network | |
| deployment_access: | |
| - unx-bec_core | |
| experiment_access: | |
| - unx-bec_core | |
| awi-bec-dev-04.psi.ch: | |
| name: AWI BEC Development VM 04 | |
| description: Development machine in the office network | |
| deployment_access: | |
| - unx-bec_core | |
| experiment_access: | |
| - unx-bec_core | |
| awi-bec-dev-05.psi.ch: | |
| name: AWI BEC Development VM 05 | |
| description: Development machine in the office network | |
| deployment_access: | |
| - unx-bec_core | |
| experiment_access: | |
| - unx-bec_core | |
| awi-bec-dev-06.psi.ch: | |
| name: AWI BEC Development VM 06 | |
| description: Development machine in the office network | |
| deployment_access: | |
| - unx-bec_core | |
| experiment_access: | |
| - unx-bec_core | |
| # Define a common VM deployment structure using YAML anchor | |
| awi-bec-dev-common: &awi_bec_dev_vm | |
| description: Development machine in the office network | |
| deployment_access: | |
| - unx-bec_core | |
| experiment_access: | |
| - unx-bec_core | |
| # Use the anchor for each VM, overriding the name field | |
| awi-bec-dev-01.psi.ch: | |
| <<: *awi_bec_dev_vm | |
| name: AWI BEC Development VM 01 | |
| awi-bec-dev-02.psi.ch: | |
| <<: *awi_bec_dev_vm | |
| name: AWI BEC Development VM 02 | |
| awi-bec-dev-03.psi.ch: | |
| <<: *awi_bec_dev_vm | |
| name: AWI BEC Development VM 03 | |
| awi-bec-dev-04.psi.ch: | |
| <<: *awi_bec_dev_vm | |
| name: AWI BEC Development VM 04 | |
| awi-bec-dev-05.psi.ch: | |
| <<: *awi_bec_dev_vm | |
| name: AWI BEC Development VM 05 | |
| awi-bec-dev-06.psi.ch: | |
| <<: *awi_bec_dev_vm | |
| name: AWI BEC Development VM 06 |
| awi-bec-dev-05.psi.ch: | ||
| name: AWI BEC Development VM 05 |
There was a problem hiding this comment.
[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.
| awi-bec-dev-06.psi.ch: | ||
| name: AWI BEC Development VM 06 |
There was a problem hiding this comment.
[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.