Skip to content

feat: add awi bec vms to realm register #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wakonig merged 1 commit into from
Sep 11, 2025
Merged

feat: add awi bec vms to realm register #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions backend/bec_atlas/deployment/realms/developer_machines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,50 @@ BL_perl:
- perl_d
experiment_access:
- perl_d

PSI_office_BEC_VM:
managers:
- unx-bec_core
deployments:
awi-bec-dev-01.psi.ch:
name: AWI BEC Development VM 01
Comment on lines +69 to +70
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.

Copilot uses AI. Check for mistakes.
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-02.psi.ch:
name: AWI BEC Development VM 02
Comment on lines +76 to +77
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.

Copilot uses AI. Check for mistakes.
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-03.psi.ch:
name: AWI BEC Development VM 03
Comment on lines +83 to +84
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.

Copilot uses AI. Check for mistakes.
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-04.psi.ch:
name: AWI BEC Development VM 04
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-05.psi.ch:
name: AWI BEC Development VM 05
Comment on lines +97 to +98
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.

Copilot uses AI. Check for mistakes.
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-06.psi.ch:
name: AWI BEC Development VM 06
Comment on lines +104 to +105
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.

Copilot uses AI. Check for mistakes.
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
Comment on lines +69 to +110
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The configuration contains significant code duplication across all six VMs. Each VM has identical structure with only the number changing. Consider using a template or loop structure if the YAML processor supports it, or document why identical configurations are necessary for maintainability.

Suggested change
awi-bec-dev-01.psi.ch:
name: AWI BEC Development VM 01
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-02.psi.ch:
name: AWI BEC Development VM 02
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-03.psi.ch:
name: AWI BEC Development VM 03
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-04.psi.ch:
name: AWI BEC Development VM 04
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-05.psi.ch:
name: AWI BEC Development VM 05
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
awi-bec-dev-06.psi.ch:
name: AWI BEC Development VM 06
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
# Define a common VM deployment structure using YAML anchor
awi-bec-dev-common: &awi_bec_dev_vm
description: Development machine in the office network
deployment_access:
- unx-bec_core
experiment_access:
- unx-bec_core
# Use the anchor for each VM, overriding the name field
awi-bec-dev-01.psi.ch:
<<: *awi_bec_dev_vm
name: AWI BEC Development VM 01
awi-bec-dev-02.psi.ch:
<<: *awi_bec_dev_vm
name: AWI BEC Development VM 02
awi-bec-dev-03.psi.ch:
<<: *awi_bec_dev_vm
name: AWI BEC Development VM 03
awi-bec-dev-04.psi.ch:
<<: *awi_bec_dev_vm
name: AWI BEC Development VM 04
awi-bec-dev-05.psi.ch:
<<: *awi_bec_dev_vm
name: AWI BEC Development VM 05
awi-bec-dev-06.psi.ch:
<<: *awi_bec_dev_vm
name: AWI BEC Development VM 06

Copilot uses AI. Check for mistakes.