25 fix godbolt #28
Merged
25 fix godbolt #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@nickelpro note that again for this repo 3.28 cmake setting doesn't work. There's no modules in this repo yet -- so I reverted to 3.25. so the ci will function correctly. Anyway, the 3.28 update isn't for free yet... |
JeffGarland
commented
Jul 5, 2025
| uses: lukka/get-cmake@latest | ||
| with: | ||
| cmakeVersion: ~3.25.0 | ||
| cmakeVersion: ~3.28.0 |
Member
Author
There was a problem hiding this comment.
@nickelpro this change is ok, but had to leave 3.25 in top level cmake
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
patrickroberts
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix godbolt by handling the case where config.hpp doesn't exist