Introduce test containers #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeveloperPaul123
approved these changes
May 5, 2025
wusatosi
commented
May 11, 2025
Comment on lines
87
to
96
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: devcontainer | ||
| context: containers | ||
| build-args: | | ||
| compiler_kind=${{ matrix.kind }} | ||
| compiler_version=${{ matrix.version }} | ||
| base_image=${{ steps.image_base.outputs.image }} | ||
| compiler_kind=${{ matrix.compilers.kind }} | ||
| compiler_version=${{ matrix.compilers.version }} | ||
| push: true | ||
| tags: ${{ env.REGISTRY }}/${{ steps.image_name.outputs.image_name }}:${{ matrix.kind }}-${{ matrix.version }} | ||
| tags: ${{ env.REGISTRY }}/${{ steps.image_name.outputs.image_name }}:${{ steps.image_name.outputs.tag }} | ||
| # https://github.com/docker/build-push-action/issues/894 |
Member
Author
There was a problem hiding this comment.
Let's move this all in a python script in the next iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be good enough for a 1.0 roll out.
Yes there's a lot of stuff I should be doing that this PR does not implement.
But this should be sufficient work for us to do a 1.0 roll out. This covers most cases already.
POC: