Use generalized testing container #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusatosi
commented
May 8, 2025
Comment on lines
68
to
71
| # If Clang 17, install a newer version of libc++ and libc++abi. | ||
| [[ ${CLANG_VERSION} = 17 ]] && sudo apt-get install libc++-dev libc++1 libc++abi-dev libc++abi1 | ||
| find /usr/lib/x86_64-linux-gnu/ -name libc++.so* || true | ||
| clang++-${CLANG_VERSION} --version |
Member
Author
There was a problem hiding this comment.
What is the rational for special treatment for clang 17?
Are we only supporting clang 17 with an updated libc++ install?
Member
Author
|
I have no idea why I broke coverage.... |
wusatosi
force-pushed
the
testing-container
branch
from
6074804 to
613817c
Compare
Pull Request Test Coverage Report for Build 15086987988Details
💛 - Coveralls |
|
#111 🌟 |
Member
Author
Huh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses newly introduced testing container (https://github.com/bemanproject/infra/pull/11) to simplify CI.