Merged
Conversation
davidlougheed
requested changes
Nov 28, 2025
davidlougheed
requested changes
Dec 19, 2025
Member
davidlougheed
left a comment
davidlougheed
left a comment
There was a problem hiding this comment.
looking better than before! I think there's more work to be done here to eliminate duplicate code though, especially with experiments result extraction and DRS URL fetching.
…act/drs_individual_overview # Conflicts: # src/modules/drs/actions.js
davidlougheed
requested changes
Jan 23, 2026
davidlougheed
changed the title
gsfk
approved these changes
Feb 5, 2026
Member
gsfk
left a comment
gsfk
left a comment
There was a problem hiding this comment.
Works great, with a couple comments:
- a few antd warnings, none of which are particularly urgent or interesting
- I've never liked the warnings from drs actions that read "something went wrong" since typically this just indicates that a file wasn't found, which often doesn't merit an error message. But code works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralizes drs fetches in ExplorerIndividualContent, adds utils.js hook for IGV-viewable files; parent dispatches all downloads and IGV subset once; removes child dispatches