chore: address low-risk Copilot AI findings (comments and strings)#556
Merged
Conversation
…ings) Cosmetic, non-behavioral changes from the AI code-quality findings: - metpo.Makefile diff-release: 'ERROR'/'WARN' -> 'Error'/'Warning' in echo messages for consistent capitalization. - metpo-edit.owl: clarify the obsolescence-reason comment that the IAO code assignment is tracked in issue #521. - qc-positive-fixture.ttl: note that metpo:1000000 / metpo:2000000 are intentional fixture-only replacement IRIs, not production terms. Behavioral findings (cross_ontology_search.py, run_sparql_metatest.sh) are intentionally left for separate review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies low-risk, non-behavioral cleanups by standardizing user-facing message-string capitalization in the ontology Makefile and adding clarifying comments in ontology/fixture files to document intentional data-modeling/test-fixture choices.
Changes:
- Standardize
diff-releaseMakefile echo messages fromERROR/WARNtoError/Warning. - Clarify in
metpo-edit.owlthat the correct obsolescence-reason code assignment work is tracked in issue #521. - Document in the SPARQL QC positive fixture that
metpo:1000000/metpo:2000000are intentional fixture-only IRIs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/sparql_qc/qc-positive-fixture.ttl |
Adds fixture documentation explaining intentional non-production replacement-target IRIs used to trigger a QC violation case. |
src/ontology/metpo.Makefile |
Normalizes diff-release diagnostic message prefixes/capitalization for consistency with other Makefile targets. |
src/ontology/metpo-edit.owl |
Adds a clarifying comment pointing to issue #521 for correct obsolescence-reason code assignment follow-up. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The fixture explanatory comment belongs with the work that normalizes that file's metpo: -> METPO: prefix (issue #16), so it is re-added there in the canonical uppercase form. This PR keeps only the Makefile and OWL findings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the zero-risk subset of the Copilot AI code-quality findings: cosmetic message-string capitalization and a clarifying comment. No behavioral change.
src/ontology/metpo.Makefile:ERROR/WARNtoError/Warningin thediff-releaseecho messages.src/ontology/metpo-edit.owl: clarify that correct IAO code assignment for the obsolescence-reason values is tracked in issue Deprecation metadata review: ~half of obsolete terms are cross-era duplicates, and obsolescence reasons look mechanically assigned #521.The QC-fixture comment finding moved to the METPO prefix-normalization PR (issue #16), where that file's
metpo:->METPO:is handled together so the comment lands in canonical uppercase form.The behavioral findings (
cross_ontology_search.py,run_sparql_metatest.sh) are deliberately left out for separate review.