Skip to content

chore: address low-risk Copilot AI findings (comments and strings) #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turbomam merged 3 commits into from
Jun 26, 2026
Merged

chore: address low-risk Copilot AI findings (comments and strings) #556

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a7e5de
chore: address low-risk Copilot AI findings (comments and message str…
turbomam Jun 26, 2026
56a7d38
chore: move QC-fixture comment to the METPO prefix-normalization PR
turbomam Jun 26, 2026
c8f269d
Merge branch 'main' into chore/copilot-ai-findings-safe
turbomam Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ontology/metpo-edit.owl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ AnnotationAssertion(rdfs:label IAO:0000231 "has obsolescence reason")

AnnotationAssertion(rdfs:label IAO:0100001 "term replaced by")

# Obsolescence reason values (display labels; correct code ASSIGNMENT is tracked in #521)
# Obsolescence reason values (display labels; correct IAO code assignment for these obsolescence reasons is tracked in issue #521)

AnnotationAssertion(rdfs:label IAO:0000226 "placeholder removed")
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/OMO_0001000> "out of scope")
Expand Down
8 changes: 4 additions & 4 deletions src/ontology/metpo.Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ diff-sheets:

# Diff current working templates against the last tagged release
diff-release:
@command -v uv >/dev/null 2>&1 || { echo "ERROR: 'uv' is required for diff-release (host-only target)."; exit 1; }
@command -v git >/dev/null 2>&1 || { echo "ERROR: 'git' is required for diff-release."; exit 1; }
@git rev-parse --is-inside-work-tree >/dev/null 2>&1 || { echo "ERROR: diff-release must be run from within a git work tree."; exit 1; }
@command -v uv >/dev/null 2>&1 || { echo "Error: 'uv' is required for diff-release (host-only target)."; exit 1; }
@command -v git >/dev/null 2>&1 || { echo "Error: 'git' is required for diff-release."; exit 1; }
@git rev-parse --is-inside-work-tree >/dev/null 2>&1 || { echo "Error: diff-release must be run from within a git work tree."; exit 1; }
@release_ref=$$(git describe --tags --abbrev=0 2>/dev/null); \
if [ -z "$$release_ref" ]; then \
echo "WARN: No git tags found; falling back to 'main'."; \
echo "Warning: No git tags found; falling back to 'main'."; \
release_ref=main; \
fi; \
cd ../.. && uv run diff-templates -a "$$release_ref" -b HEAD --cell-diffs
Expand Down
3 changes: 3 additions & 0 deletions tests/sparql_qc/qc-positive-fixture.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ metpo:9999003 a owl:Class ;
rdfs:label "fixture: a label that wrongly embeds http://example.org/foo" .

# -> multiple-replaced_by-violation.sparql : two distinct IAO:0100001 (term replaced by) values
# metpo:1000000 and metpo:2000000 are intentional fixture-only IRIs: they supply
# two distinct replacement targets for this violation case and are not declared
# here, nor expected to exist as production METPO terms.
metpo:9999004 a owl:Class ;
rdfs:label "fixture: two different replacements" ;
IAO:0100001 metpo:1000000 , metpo:2000000 .
Expand Down
Loading