Skip to content

Added KonexH743 target #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Conversation

MarcEspuna
Copy link

Target currently under betaflights hardware approval process. Schematic has already been reviewed.

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review - did not check timers or dma

Comment on lines 144 to 145
#define DEFAULT_CURRENT_METER_SCALE 100
#define DEFAULT_VOLTAGE_METER_SCALE 155
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the FC part of a stack (including ESC) ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently, it's standalone

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please leave as default

Copy link
Author

@MarcEspuna MarcEspuna Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably wrong but isn't it necessary to specify at least the DEFAULT_VOLTAGE_METER_SCALE in order to get the correct voltage reading? Since the voltage divider is on the FC I though we would need to specify it. @haslinghuis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default is 110

Copy link
Author

@MarcEspuna MarcEspuna Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check once I get the actual hw if i might need to modify this value. The voltage divider is 100kOhm for R1 and 6.8kOhm for R2 so I belive we will need to modify it.

@MarcEspuna MarcEspuna requested a review from haslinghuis March 28, 2025 00:05
MarcEspuna and others added 2 commits March 28, 2025 19:38
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
@MarcEspuna MarcEspuna requested a review from haslinghuis March 28, 2025 18:52
MarcEspuna and others added 2 commits March 28, 2025 20:40
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
@MarcEspuna
Copy link
Author

PC1 is intended to be used as a secondary pad for sensing vbat voltage. By looking at examples I understand that i should add:

#define ADC_EXTERNAL1_PIN PC1

Is it correct?

@MarcEspuna MarcEspuna requested review from haslinghuis and ot0tot April 2, 2025 18:12
Co-authored-by: Mark Haslinghuis <[email protected]>
@haslinghuis haslinghuis marked this pull request as draft April 11, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants