-
Notifications
You must be signed in to change notification settings - Fork 150
Added KonexH743 target #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review - did not check timers or dma
configs/KONEXH743/config.h
Outdated
#define DEFAULT_CURRENT_METER_SCALE 100 | ||
#define DEFAULT_VOLTAGE_METER_SCALE 155 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the FC part of a stack (including ESC) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not currently, it's standalone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then please leave as default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm probably wrong but isn't it necessary to specify at least the DEFAULT_VOLTAGE_METER_SCALE in order to get the correct voltage reading? Since the voltage divider is on the FC I though we would need to specify it. @haslinghuis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default is 110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check once I get the actual hw if i might need to modify this value. The voltage divider is 100kOhm for R1 and 6.8kOhm for R2 so I belive we will need to modify it.
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
Co-authored-by: ot0tot <[email protected]>
PC1 is intended to be used as a secondary pad for sensing vbat voltage. By looking at examples I understand that i should add: #define ADC_EXTERNAL1_PIN PC1 Is it correct? |
Co-authored-by: Mark Haslinghuis <[email protected]>
Target currently under betaflights hardware approval process. Schematic has already been reviewed.