Add oxbot Champ_H743ICM and Champ_H743MPU #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
reviewed
Apr 30, 2025
BLE will be turned off when armed. |
haslinghuis
approved these changes
May 3, 2025
ot0tot
reviewed
May 6, 2025
configs/CHAMP_H743ICM/config.h
Outdated
Comment on lines
75
to
83
| #define TIMER_PIN_MAPPING \ | ||
| TIMER_PIN_MAP(0, MOTOR1_PIN, 1, 0) \ | ||
| TIMER_PIN_MAP(1, MOTOR2_PIN, 1, 1) \ | ||
| TIMER_PIN_MAP(2, MOTOR3_PIN, 1, 2) \ | ||
| TIMER_PIN_MAP(3, MOTOR4_PIN, 1, 3) \ | ||
| TIMER_PIN_MAP(4, RX_PPM_PIN, 2, -1) \ | ||
| TIMER_PIN_MAP(5, LED_STRIP_PIN, 1, 4) \ | ||
| TIMER_PIN_MAP(6, CAMERA_CONTROL_PIN, 1, -1) \ | ||
| TIMER_PIN_MAP(7, GYRO_1_CLKIN_PIN, 1, -1) |
There was a problem hiding this comment.
RX_PPM timer conflicts with DShot bitbang on TIM8. Move motors to TIM5, RX PPM to TIM3, and add support for passive buzzers on TIM2.
Suggested change
| #define TIMER_PIN_MAPPING \ | |
| TIMER_PIN_MAP(0, MOTOR1_PIN, 1, 0) \ | |
| TIMER_PIN_MAP(1, MOTOR2_PIN, 1, 1) \ | |
| TIMER_PIN_MAP(2, MOTOR3_PIN, 1, 2) \ | |
| TIMER_PIN_MAP(3, MOTOR4_PIN, 1, 3) \ | |
| TIMER_PIN_MAP(4, RX_PPM_PIN, 2, -1) \ | |
| TIMER_PIN_MAP(5, LED_STRIP_PIN, 1, 4) \ | |
| TIMER_PIN_MAP(6, CAMERA_CONTROL_PIN, 1, -1) \ | |
| TIMER_PIN_MAP(7, GYRO_1_CLKIN_PIN, 1, -1) | |
| #define TIMER_PIN_MAPPING \ | |
| TIMER_PIN_MAP(0, MOTOR1_PIN, 2, 0) \ | |
| TIMER_PIN_MAP(1, MOTOR2_PIN, 2, 1) \ | |
| TIMER_PIN_MAP(2, MOTOR3_PIN, 2, 2) \ | |
| TIMER_PIN_MAP(3, MOTOR4_PIN, 2, 3) \ | |
| TIMER_PIN_MAP(4, RX_PPM_PIN, 1, -1) \ | |
| TIMER_PIN_MAP(5, LED_STRIP_PIN, 1, 4) \ | |
| TIMER_PIN_MAP(6, CAMERA_CONTROL_PIN, 1, -1) \ | |
| TIMER_PIN_MAP(7, GYRO_1_CLKIN_PIN, 1, -1) \ | |
| TIMER_PIN_MAP(8, BEEPER_PIN, 1, -1) |
ot0tot
reviewed
May 6, 2025
configs/CHAMP_H743ICM/config.h
Outdated
|
|
||
| #define ADC1_DMA_OPT 5 | ||
| #define ADC3_DMA_OPT 6 | ||
| #define TIMUP2_DMA_OPT 7 |
There was a problem hiding this comment.
Suggested change
| #define TIMUP2_DMA_OPT 7 | |
| #define TIMUP5_DMA_OPT 7 |
ot0tot
reviewed
May 6, 2025
configs/CHAMP_H743ICM/config.h
Outdated
Comment on lines
89
to
90
| #define BARO_I2C_INSTANCE I2CDEV_2 | ||
| #define MAG_I2C_INSTANCE I2CDEV_1 |
There was a problem hiding this comment.
Schematic has only I2C2 defined, but these pins do not appear to be accessible on the FC.
Suggested change
| #define BARO_I2C_INSTANCE I2CDEV_2 | |
| #define MAG_I2C_INSTANCE I2CDEV_1 |
ot0tot
reviewed
May 6, 2025
configs/CHAMP_H743MPU/config.h
Outdated
| #define USE_FLASH | ||
| #define USE_FLASH_M25P16 | ||
| #define USE_MAX7456 | ||
| #define USE_FLASH_W25Q128FV |
There was a problem hiding this comment.
Only needed for W25Q128JVPIQ in quad SPI mode
Suggested change
| #define USE_FLASH_W25Q128FV |
ot0tot
reviewed
May 6, 2025
configs/CHAMP_H743ICM/config.h
Outdated
| #define USE_FLASH | ||
| #define USE_FLASH_M25P16 | ||
| #define USE_MAX7456 | ||
| #define USE_FLASH_W25Q128FV |
There was a problem hiding this comment.
Only needed for W25Q128JVPIQ in quad SPI mode
Suggested change
| #define USE_FLASH_W25Q128FV |
ot0tot
reviewed
May 6, 2025
| #define CAMERA_CONTROL_PIN PE5 | ||
| #define BEEPER_PIN PA15 | ||
|
|
||
| #define TIMER_PIN_MAPPING \ |
There was a problem hiding this comment.
See comments on the ICM target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.