✨(ingestion) handle webhooks to archive offers#512
Merged
Conversation
AntoineAugusti
commented
May 12, 2026
AntoineAugusti
commented
May 12, 2026
Atheane
reviewed
May 12, 2026
Collaborator
Atheane
left a comment
There was a problem hiding this comment.
Nice and quick implementation! Some suggestions about architecture:
Is it possible to add an application layer in ingestion, with a usecase archive_offers ? Also we could add DI to managers dependencies at this point.
For signature verification, maybe we could wrap this usecase with rbac guard, maybe in a custom decorator?
Member
Author
Collaborator
vincentporte
left a comment
There was a problem hiding this comment.
Very nice.
Ideally, for upcoming PR, we should decouple ingestion PR from tycho/web one, because we want to be able to deploy only the targeted app.
Atheane
previously approved these changes
May 12, 2026
Member
Author
|
@vincentporte Thank you for your review! I've tackled your comments or asked questions. Let me know if you're ready to approve. |
e5bb8b9 to
e86bc41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Handle Talentsoft webhooks used to archive offers.
🏷️ Type of change
🔧 Changes
ingestion: handle webhooks related to archive / delete events and call thewebAPIweb: add an API to archive offers by referenceingestiontoweb🛸 Required dependencies for this change (if applicable)
🏝️ How to test (if applicable)
Steps to reproduce or test
📸 Screenshots (if applicable)
✅ Checklist