Skip to content

♻️(ingestion-presentation) move files related to archive offer#532

Merged
AntoineAugusti merged 5 commits into
mainfrom
archive_offers_endpoint_move_files
May 20, 2026
Merged

♻️(ingestion-presentation) move files related to archive offer#532
AntoineAugusti merged 5 commits into
mainfrom
archive_offers_endpoint_move_files

Conversation

@AntoineAugusti
Copy link
Copy Markdown
Member

@AntoineAugusti AntoineAugusti commented May 13, 2026

📝 Description

Follow-up of #512

  • Move ArchiveOffersView to presentation/ingestion/views
  • Move ArchiveOfferSuccessSerializer to presentation/ingestion/serializer

🏷️ Type of change

  • 🐛 Bug fix
  • 🎢 New feature (non-breaking change that adds functionality)
  • 🥁 Breaking change (a modification or feature that would cause existing functionality to stop working as expected) requiring a documentation update
  • 📚 Documentation update
  • ♻️ Refactoring
  • 🔧 Technical change

🔧 Changes

List the main changes

🛸 Required dependencies for this change (if applicable)

🏝️ How to test (if applicable)

Steps to reproduce or test

📸 Screenshots (if applicable)

✅ Checklist

  • 💅 I have added or updated the appropriate tests.
  • 📝 I have updated or added the necessary documentation.
  • 🚀 I have considered the impact on performance, security, and user experience.
  • 👀 I have requested a review from a team member.

@AntoineAugusti AntoineAugusti self-assigned this May 13, 2026
@AntoineAugusti AntoineAugusti added the modified PR: backward compatible update label May 13, 2026
Comment thread src/web/presentation/api/urls.py
Copy link
Copy Markdown
Collaborator

@vincentporte vincentporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

route should also be moved to presentation/ingestion/urls ;)

@AntoineAugusti
Copy link
Copy Markdown
Member Author

@vincentporte If we move it here this will change the URL 🤔 #532 (comment)

Do we want to prefix with /api/data?

@AntoineAugusti
Copy link
Copy Markdown
Member Author

@vincentporte Following what we discussed with URLs in #553, I have moved the code to presentation/ingestion 2e58550

I'll change what's passed in the body in a follow-up PR.

vincentporte
vincentporte previously approved these changes May 20, 2026
Copy link
Copy Markdown
Collaborator

@vincentporte vincentporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Comment thread src/web/presentation/ingestion/views.py Outdated
@AntoineAugusti AntoineAugusti merged commit 3612405 into main May 20, 2026
13 checks passed
@AntoineAugusti AntoineAugusti deleted the archive_offers_endpoint_move_files branch May 20, 2026 13:07
@github-actions github-actions Bot mentioned this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modified PR: backward compatible update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants