✨(ingestion-domain) add geographical area to Localisation#576
Merged
Conversation
5 tasks
AntoineAugusti
previously approved these changes
May 21, 2026
Member
AntoineAugusti
left a comment
AntoineAugusti
left a comment
There was a problem hiding this comment.
LGTM 👍
Unsure about the test coverage, is it sufficient according to you?
Atheane
previously approved these changes
May 21, 2026
vincentporte
commented
May 21, 2026
Collaborator
Author
vincentporte
left a comment
vincentporte
left a comment
There was a problem hiding this comment.
enum simplifié, tests du cleaner de la Localisation ajouté.
vincentporte
force-pushed
the
vp/add_area_in_localisation
branch
from
af49575 to
bda1618
Compare
AntoineAugusti
approved these changes
May 26, 2026
vincentporte
force-pushed
the
vp/add_area_in_localisation
branch
from
bda1618 to
c5f7657
Compare
AntoineAugusti
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🎸 requested for #547
🎸 Add geographical area to entity offer definition
🏷️ Type of change
✅ Checklist