✨(ingestion) expose offers/upsert endpoint#547
Merged
Conversation
vincentporte
requested review from
AntoineAugusti and
Atheane
and removed request for
AntoineAugusti
10 tasks
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
2 times, most recently
from
1753cf8 to
b81054e
Compare
Atheane
reviewed
May 20, 2026
Collaborator
Atheane
left a comment
Atheane
left a comment
There was a problem hiding this comment.
Very good start. SOme few comments for better compliance with clean archi. And missing tests for OffersUpsertView, but I am sure you are already working on it :)
Collaborator
Author
upcoming PR
|
5 tasks
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
2 times, most recently
from
9672a46 to
8691d1b
Compare
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
2 times, most recently
from
2aaac81 to
d08b3fa
Compare
vincentporte
force-pushed
the
vp/add_area_in_localisation
branch
from
bda1618 to
c5f7657
Compare
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
2 times, most recently
from
5fd91e3 to
c444e53
Compare
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
from
c444e53 to
96e5da4
Compare
vincentporte
commented
May 27, 2026
Member
AntoineAugusti
left a comment
AntoineAugusti
left a comment
There was a problem hiding this comment.
Great work 👏
My main concern is about the unique key and how we could use source_id later on.
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
2 times, most recently
from
7edba63 to
0fff262
Compare
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
from
0fff262 to
4810f23
Compare
Atheane
reviewed
May 30, 2026
Collaborator
Atheane
left a comment
Atheane
left a comment
There was a problem hiding this comment.
Very nice implementation! Just a suggestion about mapper and we are good to go!
vincentporte
force-pushed
the
vp/post_offer_endpoitn
branch
from
4810f23 to
fed62c0
Compare
… factory, simplify unit tests too
Atheane
approved these changes
Jun 2, 2026
Collaborator
Atheane
left a comment
Atheane
left a comment
There was a problem hiding this comment.
🎯 great example for all future endpoint development, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🎸 Add ingestion end point to save cleaned offers in
web🦺 All datas sent are not saved yet, updating
Offerwill be requested in an upcoming PR🏷️ Type of change
🏝️ How to test (if applicable)
✅ Checklist