Commit 9c6415c
authored
remove Debug from material strings and add LoadContext to GltfExtensi… (#22844)
# Objective
#22569 included some regressions.
At least some of them are due to the debug formatting in the asset
names.
This results in asset names like: `"DefaultMaterial"#std`.
## Solution
Remove the debug formatting.
Additionally, enable the initialization of resources like the
`StandardMaterial` built from a `GltfMaterial::default()` so that the
asset loader will have access to them. Materials like this default
material that don't exist will not call the `on_material` hook, and thus
not be initialized to be referenced later.
## Testing
multi_asset_sync and hot_reloading are fixed by this.
<img width="3776" height="2096" alt="screenshot-2026-02-06-at-19 11
31@2x"
src="https://github.com/user-attachments/assets/07a31bf9-4013-4e80-a285-9b078eb28875"
/>
<img width="3776" height="2096" alt="screenshot-2026-02-06-at-19 16
42@2x"
src="https://github.com/user-attachments/assets/5f1c1848-9469-4108-9600-5115d71d7e4c"
/>
but anisotropy still looks wrong, so this is a fix for one issue and
there appears to be more to do.
<img width="3776" height="2096" alt="screenshot-2026-02-06-at-19 17
20@2x"
src="https://github.com/user-attachments/assets/70bd1fe2-39e4-439d-a88e-e34b39aa06a8"
/>1 parent b43966b commit 9c6415c
3 files changed
Lines changed: 22 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
252 | | - | |
| 252 | + | |
253 | 253 | | |
254 | 254 | | |
255 | 255 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
| |||
453 | 456 | | |
454 | 457 | | |
455 | 458 | | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
456 | 469 | | |
457 | 470 | | |
458 | 471 | | |
| |||
462 | 475 | | |
463 | 476 | | |
464 | 477 | | |
465 | | - | |
| 478 | + | |
466 | 479 | | |
467 | | - | |
468 | | - | |
469 | | - | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
470 | 484 | | |
471 | 485 | | |
472 | 486 | | |
| |||
478 | 492 | | |
479 | 493 | | |
480 | 494 | | |
481 | | - | |
| 495 | + | |
482 | 496 | | |
483 | 497 | | |
484 | 498 | | |
| |||
0 commit comments