exclude antinuke from area select settings opton #6286
Conversation
|
It's a bit unsettling to me, how many places have to be changed to include such a feature. Maybe there is room for some refactoring? |
|
more toggles 🎉 |
| udid = spGetUnitDefID(uid) | ||
| if buildingFilter[udid] == false then | ||
| if includeBuilders or not builderFilter[udid] then | ||
| if (includeBuilders or not builderFilter[udid]) and (includeAntinuke or not antinukeFilter[udid]) then |
There was a problem hiding this comment.
This isn't even merged and has already set a bad precedent (see #6309), but this would've been fine in isolation so let's let it be.
There was a problem hiding this comment.
Maybe instead of checking if this and if this and if this, make a table of all exclusions and have a single key lookup?
There was a problem hiding this comment.
Just commented on my PR but will put here too, happy to refactor this if preferred before merging future tech debt 😅
There was a problem hiding this comment.
Sure! Steal whatever code you need I'll close this one. Marking as draft for now.
There was a problem hiding this comment.
I have included these in my PR now, thanks @SethDGamre ❤️
|
Included into #6309 |
Attributing SethDGamre beyond-all-reason#6286 Co-authored-by: SethDGamre <[email protected]>
5 participants
defaults to excluding antinuke, because I keep seeing the same thread over and over again with reputable players like Chronopolize and Blodir agreeing that you wouldn't want to area-select antinuke with your combat units. See the most recent incarnation: https://discord.com/channels/549281623154229250/1441111177605156986
This adds a settings toggle to do that.
2025-11-22.07-50-44.mp4