-
Notifications
You must be signed in to change notification settings - Fork 494
Feature Request - Radar and Jammer smart select toggles #6309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GTGalaxi
wants to merge
6
commits into
beyond-all-reason:master
Choose a base branch
from
GTGalaxi:feature/radar-jammer-smart-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature Request - Radar and Jammer smart select toggles #6309
GTGalaxi
wants to merge
6
commits into
beyond-all-reason:master
from
GTGalaxi:feature/radar-jammer-smart-select
+148
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprunk
reviewed
Nov 25, 2025
sprunk
reviewed
Nov 25, 2025
Author
|
@sprunk @SethDGamre I have refactored to a function with the table locally contained, tested all toggles to be working correctly. I would like to expand the refactor to all of the applicable toggles (buildings really) if desired, otherwise works as it is and can easily add new filters. |
Author
|
Also implemented antinuke from #6286 |
sprunk
reviewed
Nov 25, 2025
sprunk
reviewed
Nov 25, 2025
Attributing SethDGamre beyond-all-reason#6286 Co-authored-by: SethDGamre <[email protected]>
Author
sprunk
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Inspired by the discussion in this thread https://discord.com/channels/549281623154229250/1441111177605156986, and in the same fashion as #6286, I have created toggles for both radar and jammer units for the smart select based on having a
radarDistanceorradarDistanceJamproperty.radar+jammer-smart-select-scaled.mp4