Migrate Mainnet GSMs to RemoteGSM #897
Conversation
efecarranza
changed the title
🌈Test ResultsCompiling 445 files with Solc 0.8.27 Solc 0.8.27 finished in 172.84s Compiler run successful! 2025-11-17T14:51:00.306425Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/[email protected]", "diff-snapshots", "./reports/AaveV3Ethereum_GSMMigration_20251113_before.json", "./reports/AaveV3Ethereum_GSMMigration_20251113_after.json", "-o", "./diffs/AaveV3Ethereum_GSMMigration_20251113_before_AaveV3Ethereum_GSMMigration_20251113_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/[email protected]\n"Ran 12 tests for src/20251113_AaveV3Ethereum_GSMMigration/AaveV3Ethereum_GSMMigration_20251113.t.sol:AaveV3Ethereum_GSMMigration_20251113_Test [PASS] test_ghoGsmSteward_updateExposureCapUSDC() (gas: 2655503) Ran 1 test suite in 107.47s (107.45s CPU time): 12 tests passed, 0 failed, 0 skipped (12 total tests) |
|
|
||
| // OwnableFacilitator Constants | ||
| address public constant OWNABLE_FACILITATOR = 0x616AEe98F73C79FE59548Cfe7631c0baDBdA3165; | ||
| string public constant OWNABLE_FACILITATOR_NAME = 'OwnableFacilitator Gho GSMs Mainnet'; |
There was a problem hiding this comment.
| string public constant OWNABLE_FACILITATOR_NAME = 'OwnableFacilitator Gho GSMs Mainnet'; | |
| string public constant OWNABLE_FACILITATOR_NAME = 'EthereumGhoReserveGSM'; |
This is probably enough. We can also use EthereumGSM.
For reference, other facilitator names: CoreGhoDirectMinter, LidoGhoDirectMinter, HorizonGhoDirectMinter
| uint128 public constant USDC_GSM_RESERVE_LIMIT = 55_000_000 ether; | ||
| uint128 public constant USDT_GSM_RESERVE_LIMIT = 30_000_000 ether; |
There was a problem hiding this comment.
| uint128 public constant USDC_GSM_RESERVE_LIMIT = 55_000_000 ether; | |
| uint128 public constant USDT_GSM_RESERVE_LIMIT = 30_000_000 ether; | |
| uint128 public constant RESERVE_LIMIT_GSM_USDC = 55_000_000 ether; | |
| uint128 public constant RESERVE_LIMIT_GSM_USDT = 30_000_000 ether; |
| ); | ||
| } | ||
|
|
||
| function _fund(uint256 balanceUsdc, uint256 balanceUsdt) internal { |
There was a problem hiding this comment.
given that these balances are from stataUsdc and stataUsdt, are all the following operations precise? or we can incur in 1 wei diff. Also, are we ending up with 0 values in old GSM instances? can we have tests for this?
2 participants
Pre-review checklist: