Add linter exceptions for 24.2#1584
Add linter exceptions for 24.2#1584nilchia wants to merge 14 commits intobgruening:masterfrom nilchia:linter_exception
Conversation
|
@nilchia this was good? Are you still working on it? |
|
also ping @bernt-matthias |
|
Looks quite good. I guess a |
|
@bernt-matthias, does this PR conflict with this? #1561 I closed it as I thought they might conflict. |
Yours should be more up-to-date. We can close #1561. Just remove the empty files and it should be good to go. |
|
I've removed the empty files. |
All of them should be problems with URLs The R linter problems could be fixed automatically with https://github.com/bgruening/galaxytools/blob/master/.github/styler.R .. but I would do this in a separate PR |
|
No, this is not the problem. I guess your planemo is not up do date. You need to make sure that galaxy-tool-util 24.2 is used. |
t
Outdated
| @@ -0,0 +1,15 @@ | |||
| Linting tool /home/nilchia/Documents/github/bgruening/galaxytools/tools/wtdbg/wtdbg.xml | |||
There was a problem hiding this comment.
I don't think. It was a byproduct of the function.
I've removed it.
There was a problem hiding this comment.
Should have been removed automatically by egrep "WARN|ERROR" .. maybe double check everything?
There was a problem hiding this comment.
I tried the code again, it didn't remove it. 🤔
I'm not sure if egrep "WARN|ERROR" t | cut -d'(' -f2 | cut -d')' -f1 | sort -u >> $line/.lint_skip; removes the file.
There was a problem hiding this comment.
If you want you can compare with https://github.com/bernt-matthias/galaxytools/tree/lint-skip .. or just take my branch
The skip lint is added based on the code provided in #6795