Skip to content

Add linter exceptions for 24.2#1584

Closed
nilchia wants to merge 14 commits intobgruening:masterfrom
nilchia:linter_exception
Closed

Add linter exceptions for 24.2#1584
nilchia wants to merge 14 commits intobgruening:masterfrom
nilchia:linter_exception

Conversation

@nilchia
Copy link
Copy Markdown
Collaborator

@nilchia nilchia commented Mar 5, 2025

The skip lint is added based on the code provided in #6795

planemo ci_find_repos . > repos.txt
while read line
do
    echo $line;
    touch $line/.lint_skip;
    planemo l $line --skip_file $line/.lint_skip > t;
    egrep "WARN|ERROR" t | cut -d'(' -f2 | cut -d')' -f1 | sort -u >> $line/.lint_skip;
done < repos.txt

@nilchia nilchia closed this Mar 5, 2025
@nilchia nilchia deleted the linter_exception branch March 5, 2025 15:14
@bgruening
Copy link
Copy Markdown
Owner

@nilchia this was good? Are you still working on it?

@bgruening
Copy link
Copy Markdown
Owner

also ping @bernt-matthias

@bernt-matthias
Copy link
Copy Markdown
Collaborator

Looks quite good. I guess a find . -name .lint_skip -size 0 -delete should delete the empty files. Or in git find . -name .lint_skip -size 0 -exec git rm {} \;.

@nilchia nilchia restored the linter_exception branch March 5, 2025 22:13
@nilchia nilchia reopened this Mar 5, 2025
@nilchia
Copy link
Copy Markdown
Collaborator Author

nilchia commented Mar 5, 2025

@bernt-matthias, does this PR conflict with this? #1561

I closed it as I thought they might conflict.

@bernt-matthias
Copy link
Copy Markdown
Collaborator

@bernt-matthias, does this PR conflict with this? #1561

I closed it as I thought they might conflict.

Yours should be more up-to-date. We can close #1561.

Just remove the empty files and it should be good to go.

@nilchia
Copy link
Copy Markdown
Collaborator Author

nilchia commented Mar 6, 2025

I've removed the empty files.
It seems there are other linting problems as well.

@bernt-matthias
Copy link
Copy Markdown
Collaborator

It seems there are other linting problems as well.

All of them should be problems with URLs

The R linter problems could be fixed automatically with https://github.com/bgruening/galaxytools/blob/master/.github/styler.R .. but I would do this in a separate PR

@bernt-matthias
Copy link
Copy Markdown
Collaborator

No, this is not the problem. I guess your planemo is not up do date. You need to make sure that galaxy-tool-util 24.2 is used.

t Outdated
@@ -0,0 +1,15 @@
Linting tool /home/nilchia/Documents/github/bgruening/galaxytools/tools/wtdbg/wtdbg.xml
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think. It was a byproduct of the function.
I've removed it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been removed automatically by egrep "WARN|ERROR" .. maybe double check everything?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the code again, it didn't remove it. 🤔
I'm not sure if egrep "WARN|ERROR" t | cut -d'(' -f2 | cut -d')' -f1 | sort -u >> $line/.lint_skip; removes the file.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want you can compare with https://github.com/bernt-matthias/galaxytools/tree/lint-skip .. or just take my branch

repos.txt Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be removed

@nilchia nilchia closed this Jun 21, 2025
@nilchia nilchia deleted the linter_exception branch June 21, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants