recurring_lines.xml add tab as a valid character input#1597
Merged
bgruening merged 6 commits intobgruening:masterfrom Mar 25, 2025
Merged
recurring_lines.xml add tab as a valid character input#1597bgruening merged 6 commits intobgruening:masterfrom
bgruening merged 6 commits intobgruening:masterfrom
Conversation
mvdbeek
reviewed
Mar 25, 2025
Collaborator
|
Can you also add a test ? |
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
mvdbeek
reviewed
Mar 25, 2025
| </xml> | ||
| <token name="@TOOL_VERSION@">9.5</token> | ||
| <token name="@VERSION_SUFFIX@">0</token> | ||
| <token name="@VERSION_SUFFIX@">1</token> |
Collaborator
There was a problem hiding this comment.
This will bump the entire suite, and in return will bump all workflows using any of the tools in the suite. Is it not possible to override @VERSION_SUFFIX@ in the tool ?
Collaborator
Author
There was a problem hiding this comment.
It is possible but I think it is easy to maintain like this. If @bgruening prefers updating the version of this tool only, I will update it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we are using this tool in IWC DE analysis workflow to create a header line that contains tabs. If we add tab here then we can avoid an extra step of
sedand of course cleaner.