Skip to content

Updates font stack for diff table#1605

Merged
bgruening merged 1 commit intobgruening:masterfrom
itisAliRH:fix-diff-template-chinese-font
Apr 9, 2025
Merged

Updates font stack for diff table#1605
bgruening merged 1 commit intobgruening:masterfrom
itisAliRH:fix-diff-template-chinese-font

Conversation

@itisAliRH
Copy link
Copy Markdown
Contributor

This PR replaces the default monospace font with Noto Sans Mono CJK TC for improved readability and better support for CJK characters (Chinese monospace font).

Before After
before after

Replaces default monospace font with "Noto Sans Mono CJK TC" for improved readability and better support for CJK characters (chinese monospace font).
@itisAliRH itisAliRH force-pushed the fix-diff-template-chinese-font branch from 03fcfc7 to 6ef8bb6 Compare April 9, 2025 15:38
@bgruening bgruening merged commit 58a5ecc into bgruening:master Apr 9, 2025
11 checks passed
@bgruening
Copy link
Copy Markdown
Owner

Danke

@itisAliRH itisAliRH deleted the fix-diff-template-chinese-font branch April 9, 2025 15:46
@Sch-Da
Copy link
Copy Markdown
Contributor

Sch-Da commented Apr 10, 2025

Thanks @itisAliRH! Is this already implemented? I just made a test run, and the problem persists. Am I too impatient?

@Sch-Da
Copy link
Copy Markdown
Contributor

Sch-Da commented Apr 10, 2025

I checked again and for me, it is still off.

As in @itisAliRH's picture, the first lines look smooth with my dummy texts but afterwards it is still not aligned.
Screenshot 2025-04-10 at 12-03-38 Galaxy

With the original texts, it's completely dislocated in Linux.
Screenshot 2025-04-10 at 11-40-24 Galaxy

@itisAliRH
Copy link
Copy Markdown
Contributor Author

@Sch-Da Did you use the latest tool version (Galaxy Version 3.10+galaxy1). The previous jobs are still using the old version, even if you rerun them.

I ran the tool again and checked on Ubuntu:
image

Item 67 in this history

@Sch-Da
Copy link
Copy Markdown
Contributor

Sch-Da commented Apr 14, 2025

Hi @itisAliRH - my mistake. Thanks for pointing it out! I misunderstood where the changes would be made, so I did not update the tool. I will re-do this.

@Sch-Da
Copy link
Copy Markdown
Contributor

Sch-Da commented Apr 17, 2025

Hi @itisAliRH I re-checked (now correctly), and the outcome now looks amazing and super neat. Thank you so much! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants