Skip to content

Update wget in get_pdb to 1.25.0#1822

Open
RZ9082 wants to merge 4 commits intobgruening:masterfrom
RZ9082:get_pdb
Open

Update wget in get_pdb to 1.25.0#1822
RZ9082 wants to merge 4 commits intobgruening:masterfrom
RZ9082:get_pdb

Conversation

@RZ9082
Copy link
Copy Markdown
Collaborator

@RZ9082 RZ9082 commented Mar 23, 2026

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Not sure about versioning. Should we keep it like this or take the wget version? also should we add a suffix?

Comment thread chemicaltoolbox/data_source/get_pdb/get_pdb.xml Outdated
@bgruening
Copy link
Copy Markdown
Owner

.. WARNING: Missing shed metadata field [homepage_url] for repository

Do we have a hypothesis why the old wget is failing now? Is that because of the container?

@RZ9082
Copy link
Copy Markdown
Collaborator Author

RZ9082 commented Mar 23, 2026

.. WARNING: Missing shed metadata field [homepage_url] for repository

Do we have a hypothesis why the old wget is failing now? Is that because of the container?

@mira-miracoli found the issue, the container has no DNS resolver configuration.

@bgruening should the old container be fixed?

@bgruening
Copy link
Copy Markdown
Owner

With a lot of time I would say we should fix the old container. But... I'm fine with shipping this. However are we sure this new container works with singularity? @RZ9082 can you test the old version in docker please. Just ran planemo --biocontainers on the master branch

@mira-miracoli
Copy link
Copy Markdown

With a lot of time I would say we should fix the old container. But... I'm fine with shipping this. However are we sure this new container works with singularity? @RZ9082 can you test the old version in docker please. Just ran planemo --biocontainers on the master branch

I tested with docker and that works indeed, docker is mounting my laptop's resolv.conf.
Singularity complains that the container has no target /etc/resolv.conf and it can therefore not mount it.

@mira-miracoli
Copy link
Copy Markdown

@bgruening
Copy link
Copy Markdown
Owner

No idea, I was expecting mounting in the /etc/resolve.conf and not ssl ... but it seems to work for Nate? Maybe ask him?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants