Skip to content

chore: Revert to upstream nifti-reader-js #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
effigies wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: Revert to upstream nifti-reader-js #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
762fa31
chore: Mark deno.lock binary
effigies Sep 2, 2026
1776212
chore: Revert to upstream nifti-reader-js
effigies Sep 2, 2026
d22f17a
doc: Changelog entry
effigies Sep 2, 2026
1de61a2
chore: Bump deno version
effigies Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
bids-validator/src/.git-meta.json export-subst
src/tests/bom-utf8.json text eol=lf
deno.lock binary merge=binary
2 changes: 1 addition & 1 deletion .github/workflows/deno_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
run: echo version=$( git describe ) >> $GITHUB_OUTPUT
- uses: denoland/setup-deno@667a34cdef165d8d2b2e98dde39547c9daac7282 # v2.0.4
with:
deno-version: v2.6.6
deno-version: v2.9.6
- run: deno --node-modules-dir=auto -A ./build.ts
- run: deno run -A ./dist/validator/bids-validator.js --version
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/web_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: denoland/setup-deno@667a34cdef165d8d2b2e98dde39547c9daac7282 # v2.0.4
with:
deno-version: v2.6.6
deno-version: v2.9.6
- run: deno task build
working-directory: ./web
- name: Upload GitHub Pages artifact
Expand All @@ -52,7 +52,7 @@ jobs:
path: dev
- uses: denoland/setup-deno@667a34cdef165d8d2b2e98dde39547c9daac7282 # v2.0.4
with:
deno-version: v2.6.6
deno-version: v2.9.6
- name: Build release/target
run: deno task build
working-directory: stable/web
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=denoland/deno:alpine-2.4.5
ARG BASE_IMAGE=denoland/deno:alpine-2.9.6
FROM ${BASE_IMAGE} AS build
WORKDIR /src

Expand Down
1 change: 1 addition & 0 deletions build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ const result = await esbuild.build({
'buffer': true,
'process': true,
'crypto': true,
'module': true,
'worker_threads': false,
},
}),
Expand Down
5 changes: 5 additions & 0 deletions changelog.d/20260902_114722_markiewicz_HEAD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Infrastructure

- Drop fork of [nifti-reader-js][] and depend on upstream module.

[nifti-reader-js]: https://www.npmjs.com/package/nifti-reader-js
2 changes: 1 addition & 1 deletion deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"pluralize": "npm:pluralize@^8.0.0",
"@ignore": "npm:ignore@^7.0.5",
"@libs/xml": "jsr:@libs/xml@^7.0.4",
"@mango/nifti": "npm:@bids/nifti-reader-js@^0.6.9",
"@mango/nifti": "npm:nifti-reader-js@^0.8.0",
"@std/assert": "jsr:@std/assert@^1.0.19",
"@std/async": "jsr:@std/async@^1.4.0",
"@std/fmt": "jsr:@std/fmt@^1.0.10",
Expand Down
37 changes: 25 additions & 12 deletions deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion web/deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion web/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { nodePolyfills } from "npm:vite-plugin-node-polyfills@0.22.0"
import "npm:react@^18.2.0"
import "npm:react-dom@^18.2.0"
import "npm:react-markdown@^10.1.0"
import "npm:canvas-confetti@1.9.3"
import "npm:canvas-confetti@1.9.4"

/**
* Vite plugin to hack a bug injected by the default assetImportMetaUrlPlugin
Expand Down
Loading