Add timePointListeners() and getConverterSetups() to AbstractViewerPanel#216
Merged
tpietzsch merged 3 commits intoMar 1, 2026
Merged
Conversation
Move ConverterSetups creation from ViewerFrame/BdvHandlePanel into ViewerPanel so that getConverterSetups() can be provided at the AbstractViewerPanel level. This allows downstream code (e.g. bdv-playground) to use AbstractViewerPanel as a unified interface for both BDV and BVV without a separate adapter. Adresses bigdataviewer#158
redirect to ViewerPanel.getConverterSetups() instead
tpietzsch
pushed a commit
to NicoKiaru/bigvolumeviewer-core
that referenced
this pull request
Mar 1, 2026
Replace CopyOnWriteArrayList<TimePointListener> with Listeners.SynchronizedList to match BDV's pattern. Deprecate addTimePointListener()/removeTimePointListener() in favor of the new timePointListeners() method. Companion to bigdataviewer/bigdataviewer-core#216
tpietzsch
pushed a commit
to bigdataviewer/bigvolumeviewer-core
that referenced
this pull request
Mar 1, 2026
Replace CopyOnWriteArrayList<TimePointListener> with Listeners.SynchronizedList to match BDV's pattern. Deprecate addTimePointListener()/removeTimePointListener() in favor of the new timePointListeners() method. Companion to bigdataviewer/bigdataviewer-core#216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body:
Summary
Adds two abstract methods to
AbstractViewerPanelso that downstream code (e.g. bdv-playground) can use it as a unified interface for both BigDataViewer and BigVolumeViewer, without maintaining a separate adapter class.abstract Listeners<TimePointListener> timePointListeners()toAbstractViewerPanelabstract ConverterSetups getConverterSetups()toAbstractViewerPanelConverterSetupscreation intoViewerPanel(previously owned byViewerFrame/BdvHandlePanel).ViewerFrameandBdvHandlePanelnow delegate toviewer.getConverterSetups().Addresses bigdataviewer/bigdataviewer-core#27
Files changed
AbstractViewerPanel.java— two new abstract method declarationsViewerPanel.java— newConverterSetupsfield +getConverterSetups()impl,@OverrideontimePointListeners()ViewerFrame.java— removed localConverterSetupsfield/creation, delegates to viewerBdvHandlePanel.java— same:setups = viewer.getConverterSetups()instead of creating its own