Implement timePointListeners() for AbstractViewerPanel harmonization#30
Open
NicoKiaru wants to merge 3 commits intobigdataviewer:masterfrom
Open
Implement timePointListeners() for AbstractViewerPanel harmonization#30NicoKiaru wants to merge 3 commits intobigdataviewer:masterfrom
NicoKiaru wants to merge 3 commits intobigdataviewer:masterfrom
Conversation
Replace CopyOnWriteArrayList<TimePointListener> with Listeners.SynchronizedList to match BDV's pattern. Deprecate addTimePointListener()/removeTimePointListener() in favor of the new timePointListeners() method. Companion to bigdataviewer/bigdataviewer-core#216
Use the new SynchronizedViewerState instead of the deprecated bdv.viewer.state.ViewerState. In general, try to make VolumneViewerPanel more similar to ViewerPanel. In particular, revise synchronization and animator handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to #27 ; implements the new
timePointListeners()abstract method fromAbstractViewerPanelso that BVV'sVolumeViewerPanelsatisfies the unified interface.CopyOnWriteArrayList<TimePointListener>withListeners.SynchronizedList(matches BDV's pattern)timePointListeners()returningListeners<TimePointListener>addTimePointListener()/removeTimePointListener()as wrappers@Overrideon existinggetConverterSetups()BvvHandle.remove()to useviewer.timePointListeners().remove(l)Requires bigdataviewer-core with the harmonized
AbstractViewerPanel(the companion PR above).Files changed
VolumeViewerPanel.java— listener refactor + new method + deprecationsBvvHandle.java— one-line update inremove()