Skip to content

ci: create GitHub release after pushing version tags#761

Merged
dianjuar merged 1 commit into
mainfrom
ci/github-release-after-tag-push
May 31, 2026
Merged

ci: create GitHub release after pushing version tags#761
dianjuar merged 1 commit into
mainfrom
ci/github-release-after-tag-push

Conversation

@dianjuar
Copy link
Copy Markdown
Member

@dianjuar dianjuar commented May 31, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What is the current behavior?

After #759, the publishment workflow runs @jscutlery/semver:github as a postTarget of nx version, which creates the GitHub release before version tags are pushed to the remote. That ordering can cause gh release create to run against tags that only exist locally at that point.

Issue Number: #244

What is the new behavior?

The github target is removed from the semver postTargets chain. The publishment workflow now runs npx nx github ngx-deploy-npm in a dedicated step after ad-m/github-push-action pushes commits and tags, with GITHUB_TOKEN scoped to that step.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Follow-up to #759. Related to #244.

Run the semver github target as a dedicated publishment step after tags
are pushed so gh release create targets refs that exist on the remote.

Related to #244

Co-authored-by: Cursor <cursoragent@cursor.com>
@dianjuar dianjuar merged commit ad81845 into main May 31, 2026
21 of 23 checks passed
@dianjuar dianjuar deleted the ci/github-release-after-tag-push branch May 31, 2026 03:11
@github-actions
Copy link
Copy Markdown

Release preview

Simulates squash merge into main using the PR title as the commit message.
Only changes under packages/ngx-deploy-npm affect the version.

PR title: ci: create GitHub release after pushing version tags

Semantic commit (PR title)

✅ Valid conventional commit

Version

9.1.09.2.0

Changelog preview

## [9.2.0](https://github.com/bikecoders/ngx-deploy-npm/compare/ngx-deploy-npm-9.1.0...ngx-deploy-npm-9.2.0) (2026-05-31)


### Features

* **ngx-deploy-npm:** extend checkExisting with skip mode and checkTag ([#749](https://github.com/bikecoders/ngx-deploy-npm/issues/749)) ([1250a91](https://github.com/bikecoders/ngx-deploy-npm/commit/1250a9189f46e62e56b03cde76522663c9918467))
* **ngx-deploy-npm:** forward npm publish passthrough flags ([#751](https://github.com/bikecoders/ngx-deploy-npm/issues/751)) ([371751b](https://github.com/bikecoders/ngx-deploy-npm/commit/371751b0f41fac6acb6597d6860ae4a88f86aecc))
* **ngx-deploy-npm:** log post-publish summary with streaming tarball size ([#750](https://github.com/bikecoders/ngx-deploy-npm/issues/750)) ([dbfe288](https://github.com/bikecoders/ngx-deploy-npm/commit/dbfe288a69f52f3749a6d80d4c54ddc87ea8afb0)), closes [#749](https://github.com/bikecoders/ngx-deploy-npm/issues/749)


### Bug Fixes

* **ngx-deploy-npm:** apply packageVersion transiently during dry-run ([#752](https://github.com/bikecoders/ngx-deploy-npm/issues/752)) ([cf7013f](https://github.com/bikecoders/ngx-deploy-npm/commit/cf7013f6311c1cbe3ab81dfe08b366ac323265df))
* **ngx-deploy-npm:** resolve open SonarCloud static analysis issues ([#746](https://github.com/bikecoders/ngx-deploy-npm/issues/746)) ([599ac29](https://github.com/bikecoders/ngx-deploy-npm/commit/599ac2971841cdec6fd720428ed2ae5546492ed5))

Generated by CI (PR Release Preview). Actual release runs on merge via publishment.yml.

Notes: Preview uses only the PR title (squash merge). Changes outside packages/ngx-deploy-npm do not trigger a version bump. Breaking changes must appear in the title (e.g. feat!:), not only in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant