Skip to content

Add --repeat to examples#916

Closed
fkondej wants to merge 1 commit intomainfrom
fkondej/eng2-260-add-repeat-to-examples
Closed

Add --repeat to examples#916
fkondej wants to merge 1 commit intomainfrom
fkondej/eng2-260-add-repeat-to-examples

Conversation

@fkondej
Copy link
Copy Markdown
Contributor

@fkondej fkondej commented Sep 2, 2025

No description provided.

@linear
Copy link
Copy Markdown

linear bot commented Sep 2, 2025

ENG2-260 [benches] Improve results produced by example benchmarks

  • Improve tracing-profile
    • trace file name
    • trace directory structure
  • Improve examples logic in monbijou
    • improve spans
    • port phase and step spans idea form binius repo
    • implement --repeat
    • export JSON reports

Reasoning - currently we are using quite complex bash and python scripts in CI that are tightly coupled to existing tracing-profile functionality, that parse results, iterate, move and rename files.

Copy link
Copy Markdown
Contributor Author

fkondej commented Sep 2, 2025


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fkondej fkondej self-assigned this Sep 2, 2025
@fkondej fkondej force-pushed the fkondej/eng2-260-add-repeat-to-examples branch 2 times, most recently from 2001555 to 80a3f42 Compare September 2, 2025 15:18
@fkondej fkondej mentioned this pull request Sep 2, 2025
Copy link
Copy Markdown
Collaborator

jimpo commented Sep 2, 2025

How much of a difference does this make in the timings?

@fkondej fkondej force-pushed the fkondej/eng2-260-add-repeat-to-examples branch 2 times, most recently from 132c650 to 2a057a7 Compare September 3, 2025 09:16
@fkondej
Copy link
Copy Markdown
Contributor Author

fkondej commented Sep 3, 2025

How much of a difference does this make in the timings?

There is no timing difference. This change should simplify CI scripts and make them more stable.

@fkondej fkondej force-pushed the fkondej/eng2-260-add-repeat-to-examples branch 12 times, most recently from 6f16301 to 411e449 Compare September 4, 2025 00:52
Comment thread .github/scripts/generate_benchmark_report.py
Comment thread crates/examples/src/cli.rs Outdated
Comment thread crates/examples/src/cli.rs Outdated
@fkondej fkondej force-pushed the fkondej/eng2-260-add-repeat-to-examples branch from 411e449 to 3cc50b1 Compare September 4, 2025 12:58
Copy link
Copy Markdown
Collaborator

jimpo commented Sep 16, 2025

@fkondej Can you take out of draft or close this?

@fkondej
Copy link
Copy Markdown
Contributor Author

fkondej commented Sep 16, 2025

Closing - will use part of this logic in a separate PR.

@fkondej fkondej closed this Sep 16, 2025
@fkondej fkondej deleted the fkondej/eng2-260-add-repeat-to-examples branch September 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants