Skip to content

Add --json to examples#918

Closed
fkondej wants to merge 1 commit intographite-base/918from
fkondej/eng2-260-add-json-to-examples
Closed

Add --json to examples#918
fkondej wants to merge 1 commit intographite-base/918from
fkondej/eng2-260-add-json-to-examples

Conversation

@fkondej
Copy link
Copy Markdown
Contributor

@fkondej fkondej commented Sep 2, 2025

No description provided.

@linear
Copy link
Copy Markdown

linear bot commented Sep 2, 2025

ENG2-260 [benches] Improve results produced by example benchmarks

  • Improve tracing-profile
    • trace file name
    • trace directory structure
  • Improve examples logic in monbijou
    • improve spans
    • port phase and step spans idea form binius repo
    • implement --repeat
    • export JSON reports

Reasoning - currently we are using quite complex bash and python scripts in CI that are tightly coupled to existing tracing-profile functionality, that parse results, iterate, move and rename files.

@fkondej fkondej mentioned this pull request Sep 2, 2025
Copy link
Copy Markdown
Contributor Author

fkondej commented Sep 2, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fkondej fkondej self-assigned this Sep 2, 2025
Copy link
Copy Markdown
Collaborator

jimpo commented Sep 2, 2025

Can you elaborate on the purpose of this in the PR description? Why not use a tracing subscriber?

@fkondej fkondej changed the base branch from fkondej/eng2-260-add-repeat-to-examples to graphite-base/918 September 3, 2025 09:14
@fkondej
Copy link
Copy Markdown
Contributor Author

fkondej commented Sep 4, 2025

won't need anymore

@fkondej fkondej closed this Sep 4, 2025
@fkondej fkondej deleted the fkondej/eng2-260-add-json-to-examples branch September 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants