Skip to content

fix(create_knowledge_graph): print on stderr#9

Open
jdreo wants to merge 2 commits into
biocypher:mainfrom
jdreo:main
Open

fix(create_knowledge_graph): print on stderr#9
jdreo wants to merge 2 commits into
biocypher:mainfrom
jdreo:main

Conversation

@jdreo
Copy link
Copy Markdown

@jdreo jdreo commented Jan 19, 2026

Fixes issue 478 (left on biocypher)

@slobentanzer
Copy link
Copy Markdown
Collaborator

Hi @jdreo, thanks! I am not sure, what does this change? Also in relation to the issue @mevol opened?

I think she assumed it was left in, is there a problem with printing to console in a script to show the paths we used?

@jdreo
Copy link
Copy Markdown
Author

jdreo commented Jan 21, 2026

There's no problem printing log/side information, unless it's on stdout. Log info should be on stderr, so that an overarching script may manipulate what's the product of the script aside from the logs.

For the case of the template, I think it should print on stdout the import call file, which is (now) returned by write_import_calls. That way, the calling script may know where are the current data outputs.

@mevol
Copy link
Copy Markdown

mevol commented Jan 21, 2026

Yes, I assumed the print was left in by mistake. If this was for capturing output I would have expected this to come from a logger not a simple print.

@slobentanzer
Copy link
Copy Markdown
Collaborator

@jdreo I think that's a solution to a different problem (good nonetheless). The print statement was to show the downloaded files. But I see why it may seem like left in by mistake. I'll merge this and log the download paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants