fix(create_knowledge_graph): print on stderr#9
Conversation
|
There's no problem printing log/side information, unless it's on stdout. Log info should be on stderr, so that an overarching script may manipulate what's the product of the script aside from the logs. For the case of the template, I think it should print on stdout the import call file, which is (now) returned by |
|
Yes, I assumed the print was left in by mistake. If this was for capturing output I would have expected this to come from a logger not a simple print. |
|
@jdreo I think that's a solution to a different problem (good nonetheless). The print statement was to show the downloaded files. But I see why it may seem like left in by mistake. I'll merge this and log the download paths. |
Fixes issue 478 (left on biocypher)