feat(lint): implement useExhaustiveSwitchCases - typescript-eslint/switch-exhaustiveness-check
#5762
Conversation
github-actions
bot
added
A-Project
|
I'm thrilled!!!! 🤩 |
CodSpeed Performance ReportMerging #5762 will not alter performanceComparing Summary
|
siketyan
force-pushed
the
feat/use-exhaustive-switch-cases
branch
from
b22c4e1 to
7a486b1
Compare
…/switch-exhaustiveness-check`
siketyan
force-pushed
the
feat/use-exhaustive-switch-cases
branch
from
7a486b1 to
d16049a
Compare
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Looks good. We need to add the second pillar to the diagnostic messages
crates/biome_js_analyze/src/lint/nursery/use_exhaustive_switch_cases.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_exhaustive_switch_cases.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_exhaustive_switch_cases.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_exhaustive_switch_cases.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_exhaustive_switch_cases.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_exhaustive_switch_cases.rs
Outdated
Show resolved
Hide resolved
# Conflicts: # crates/biome_js_analyze/tests/spec_tests.rs
|
I am going to merge this after #5777, which will change some part that this rule relies on. |
arendjr
left a comment
arendjr
left a comment
There was a problem hiding this comment.
Love it, and well done with the solid test cases!
Thanks for waiting for the refactor too 🙏
# Conflicts: # crates/biome_configuration/src/analyzer/linter/rules.rs # crates/biome_js_analyze/src/lint/nursery.rs # crates/biome_js_type_info/src/flattening.rs # crates/biome_js_type_info/src/type_info.rs
# Conflicts: # crates/biome_configuration/src/analyzer/linter/rules.rs # crates/biome_js_analyze/src/lint/nursery.rs # crates/biome_js_analyze/src/services/typed.rs
siketyan
force-pushed
the
feat/use-exhaustive-switch-cases
branch
from
37c2fbd to
3af6b6d
Compare
| if let Some(expr) = | ||
| JsExpressionStatement::cast_ref(node).and_then(|node| node.expression().ok()) |
There was a problem hiding this comment.
@arendjr This prevented the type of const declarations and reference expressions to be resolved. Is this condition correct? Changing this to AnyJsExpression fixed the issue, but it can occur performance regression.
There was a problem hiding this comment.
I had indeed avoided that for performance reasons, and this was all I needed for it to work with noFloatingPromises... but indeed that doesn't scale across the board :(
I'd be happy to relax this to support AnyJsExpression, but I'm afraid we need to resolve the performance issues first. I do have some hope my current PR may help with that 🤞
There was a problem hiding this comment.
For now, registering types for the discriminant and the case expressions is sufficient for the rule: bdfc07b
siketyan
force-pushed
the
feat/use-exhaustive-switch-cases
branch
from
3af6b6d to
609ed92
Compare
siketyan
force-pushed
the
feat/use-exhaustive-switch-cases
branch
from
609ed92 to
cc5204d
Compare
# Conflicts: # crates/biome_configuration/src/analyzer/linter/rules.rs # crates/biome_js_analyze/src/lint/nursery.rs # crates/biome_js_type_info/src/flattening.rs
…/switch-exhaustiveness-check` (#5762)
4 participants
Summary
Initial implementation of a new rule
useExhaustiveSwitchCases, which is an equivalent totypescript-eslint/switch-exhaustiveness-check. I left adding options for future improvement.Test Plan
Added snapshot tests.