Skip to content

Added plotter argument to PhenotypicPhasePlaneResult.plot() - #289

Open
djinnome wants to merge 1 commit into
biosustain:develfrom
djinnome:patch-1
Open

Added plotter argument to PhenotypicPhasePlaneResult.plot()#289
djinnome wants to merge 1 commit into
biosustain:develfrom
djinnome:patch-1

Conversation

@djinnome

Copy link
Copy Markdown

Solving issue #288

Thanks to @jafemm for discovering this issue

Solving  issue biosustain#288

Thanks to @jafemm for discovering this issue
@carrascomj
carrascomj self-requested a review November 25, 2021 07:57
@codecov

codecov Bot commented Nov 25, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.18%. Comparing base (8b1adb7) to head (e7f5859).
⚠️ Report is 1 commits behind head on devel.

Files with missing lines Patch % Lines
...ain_design/pathway_prediction/pathway_predictor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #289      +/-   ##
==========================================
- Coverage   63.35%   63.18%   -0.18%     
==========================================
  Files          58       58              
  Lines        5786     5786              
  Branches     1109      997     -112     
==========================================
- Hits         3666     3656      -10     
- Misses       1902     1913      +11     
+ Partials      218      217       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carrascomj carrascomj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

The python 3.6 tests are failing but that does not have anything to do with this PR.

@mrodrigueze

Copy link
Copy Markdown

¿Cómo hago para visualizar en 3D una variable de tipo cameo.flux_analysis.analysis.PhenotypicPhasePlaneResult?
result_3D.plot(plotter) #Este es el código que use

AttributeError: 'DataFrame' object has no attribute 'as_matrix'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants