Fix fitting (for logistic regression) - #74
Draft
enryH wants to merge 36 commits into
Draft
Conversation
- highlight equations - distinguish between lag and intial value of measurement curve
- group fitting functions explicitly
- fit.py is equivalent as fit/__init__.py w.r.t to importing it
- realize that ln(N0) has to be fitted as function itself is non-zero at t=0 in most cases
- negative times are not tested. should they exist?
…at N0 is - N0 = N(t=lag) - N(0) is non-zero itself Both leads to some additional sublte complications to calculate a global shift in y
- ln_N used to allow for an offset to be calculated (needs to be documented for fitting)
…er mu) - lag estimation is arbitrary -> only use heuristics for lag estimation.
- key point: OD_phen_classic has no real lack in log-space (as it is a linear)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add examples for model fitting
fitting functions take linear scale measurements
N0asmin(N)and update inference to correctly generate the data