fix: Deprecated Settings from Qt.labs.settings - #781
Closed
uqlidi wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
we needed to bump ubuntu to 26.04 because the older version doesn't ship Settings in QtCore see: https://github.com/bitcoin-core/gui-qml/actions/runs/29263460032/job/86863608017 |
Member
Actually, we maintain backward compatibility with our minimum required Qt version: https://github.com/bitcoin/bitcoin/blob/dc282ff31d1cc97507530a541d9cec8a8f6a6ef4/doc/dependencies.md |
Member
|
Closing in favour of #795. |
hebasto
added a commit
that referenced
this pull request
Jul 19, 2026
ea12a28 ci: Add Ubuntu 26.04 job to cover Qt >= 6.5 code path (Hennadii Stepanov) a8e0403 qml: Use `Settings` type from `QtCore` on Qt >= 6.5 (Hennadii Stepanov) 3996808 test: Load QML test files from the resource system (Hennadii Stepanov) Pull request description: The `Settings` type from `Qt.labs.settings` is deprecated since Qt 6.5. Introduce a build-time-selected `AppSettings` compatibility type that uses `QtCore` on Qt >= 6.5 and `Qt.labs.settings` on older versions, keeping compatibility with the minimum required Qt 6.2. Fixes #780. An alternative to #781. ACKs for top commit: johnny9: ACK ea12a28 Tree-SHA512: 1b67035ae6ecbc5e3a2b5641f22c53ca402c51d89906224962301a143849611069b336aef5b244576acdf353142bddf107c4234f24df958962a3a33fe63a8ad0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use
QtCoreinstead ofQt.labs.settingsforSettingsbecause it's deprecated and would be removed laterfix #780