qml: Use Settings type from QtCore on Qt >= 6.5 - #795
Merged
Conversation
hebasto
marked this pull request as draft
July 17, 2026 21:28
hebasto
marked this pull request as ready for review
July 17, 2026 23:04
Member
Author
Run `bitcoinqml_qmltests` against QML files embedded into the test binary instead of the source tree, so that components resolve in the same `qrc:/` URL space as in the application. This is required for the following commit.
The `Settings` type from `Qt.labs.settings` is deprecated since Qt 6.5. Introduce a build-time-selected `AppSettings` compatibility type that uses `QtCore` on Qt >= 6.5 and `Qt.labs.settings` on older versions, keeping compatibility with the minimum required Qt 6.2.
The existing Ubuntu 24.04 job builds against Qt 6.4, which exercises only the `Qt.labs.settings` variant of the `AppSettings` type. Add a job with Qt 6.10 to also cover the `QtCore` variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Settingstype fromQt.labs.settingsis deprecated since Qt 6.5. Introduce a build-time-selectedAppSettingscompatibility type that usesQtCoreon Qt >= 6.5 andQt.labs.settingson older versions, keeping compatibility with the minimum required Qt 6.2.Fixes #780.
An alternative to #781.