-
Notifications
You must be signed in to change notification settings - Fork 389
fix(wallet): added the validation of UTXO data for build_fee_bump #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @ValuedMammal for This PR. Is the new error variant suitable. Or I should look for existing error variants as you have suggested with #1911 . What do you suggest? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ItshMoh. you've done a great job working on this PR.
I will suggest you add some unit tests to cover your new implementation. This will help ensure that edge cases, such as validation UTXO data, are handled correctly. Thanks!
Hey @ItshMoh, this PR needs to be closed and moved to the new bdk_wallet repo. Here's how:
|
@ItshMoh since there is no reply for a few weeks, I will be closing this PR. |
Description
It fixes the Issue bitcoindevkit/bdk_wallet#51 . In this PR we are checking the size of the prev_tx.output list for ensuring that it contains the output referred by each input of the transaction to be bumped.
Notes to the reviewers
here prev_tx.output size is checked. Also changed the .map form .and_then for proper handling of Result.
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingBugfixes: