Allow malformed MIME types: ignore BadContentTypeFormatExceptions #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching calendar data, if the server responds with a malformed MIME type in the Content-Type header, we now log a warning and proceed without a content type instead of failing with error message.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances error handling in the calendar fetching logic to gracefully handle malformed MIME types in server responses. Instead of failing when a server sends an invalid Content-Type header, the application now logs a warning and proceeds with calendar processing.
Changes:
- Added exception handling for
BadContentTypeFormatExceptionwhen parsing Content-Type headers - Modified the success path to use a nullable ContentType variable, defaulting to null when parsing fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sunkup
deleted the
784-allow-malformed-mime-types---ignore-badcontenttypeformatexceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some servers respond with a malformed MIME type in the Content-Type header, which has ICSx⁵ fail with an error message. ICSx⁵ should not fail on those but try to parse the returned calendar and add the subscription anyways.
Short description
When fetching calendar data, if the server responds with a malformed MIME type in the Content-Type header, we now log a warning and proceed without a content type instead of failing with error message.
Checklist