Skip to content

Allow malformed MIME types: ignore BadContentTypeFormatExceptions #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunkup merged 3 commits into from
Jan 28, 2026
Merged

Allow malformed MIME types: ignore BadContentTypeFormatExceptions #787

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c968ef
Allow malformed MIME types: ignore BadContentTypeFormatExceptions
sunkup Jan 15, 2026
67246ba
Add space
sunkup Jan 15, 2026
47e644a
Add tests
sunkup Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions app/src/main/java/at/bitfire/icsdroid/CalendarFetcher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import io.ktor.client.request.basicAuth
import io.ktor.client.request.get
import io.ktor.client.request.header
import io.ktor.client.statement.bodyAsChannel
import io.ktor.http.BadContentTypeFormatException
import io.ktor.http.ContentType
import io.ktor.http.HttpHeaders
import io.ktor.http.HttpStatusCode
Expand Down Expand Up @@ -154,16 +155,23 @@ open class CalendarFetcher(
val statusCode = response.status
when {
// 20x
statusCode.isSuccess() ->
statusCode.isSuccess() -> {
val contentType: ContentType? = try {
response.contentType()
} catch (e: BadContentTypeFormatException) {
Log.w(Constants.TAG,"Failed to parse content type. Continuing without.", e)
null
}
onSuccess(
response.bodyAsChannel().toInputStream(),
response.contentType(),
contentType,
response.headers[HttpHeaders.ETag],
response.headers[HttpHeaders.LastModified]?.let {
HttpUtils.parseDate(it)?.time
},
null
)
}

// 30x
statusCode == HttpStatusCode.NotModified -> onNotModified()
Expand Down